add module to enable bringing your own bucket file carving destination #15206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfairburn
reviewed
Nov 20, 2023
| } | ||
|
|
||
| # Create an S3 bucket with server-side encryption using the customer-managed key | ||
| resource "aws_s3_bucket" "carve_results_bucket" { |
There was a problem hiding this comment.
should we have a aws_s3_bucket_public_access_block for this bucket just to cover these are set explicitly rather than implicitly?
rfairburn
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a new terraform module that will make it easy to configure Fleet instances for S3 backend for file carving results. Its intended to be applied in two phases.
Checklist for submitter