Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming Activities feature branch #25450

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

mna
Copy link
Member

@mna mna commented Jan 15, 2025

Feature branch for #22866

For #23912

Add the ability to cancel upcoming activities in the UI. This adds that
functionality but also changes the design of the activities used on the
past and upcoming feeds. This PR includes:

**new UI for activities on past and upcoming activity feeds **


![image](https://github.com/user-attachments/assets/f970a4fe-a04b-49cb-8b76-bbaf1f8dff02)

**ability to cancel an upcoming activity**


![image](https://github.com/user-attachments/assets/00107135-6a62-40d6-8c8d-9f16b7ae049a)

**changes to the global activities to use the new activity behaviour and
styles:**


![image](https://github.com/user-attachments/assets/d5bbd7e4-9879-45d0-b12c-188067c4253f)


> NOTE: there will need to be more work done to integrate with the API
when this is ready. That will be done in another PR.

- [ ] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
- [ ] Added/updated automated tests
- [x] Manual QA for all new/changed functionality
relates to #23912

This renders the fleet avatar if the activity is fleet initiated 


![image](https://github.com/user-attachments/assets/cb28f6e8-e5bd-4dad-8c68-bdce2ee6349e)

- [ ] Added/updated automated tests
- [ ] Manual QA for all new/changed functionality
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 29 lines in your changes missing coverage. Please review.

Project coverage is 63.52%. Comparing base (732f46c) to head (1968db1).

Files with missing lines Patch % Lines
...vityFeed/GlobalActivityItem/GlobalActivityItem.tsx 60.71% 11 Missing ⚠️
frontend/components/ActivityItem/ActivityItem.tsx 70.00% 9 Missing ⚠️
.../DashboardPage/cards/ActivityFeed/ActivityFeed.tsx 33.33% 4 Missing ⚠️
frontend/services/entities/activities.ts 0.00% 3 Missing ⚠️
frontend/utilities/endpoints.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #25450      +/-   ##
==========================================
- Coverage   63.59%   63.52%   -0.08%     
==========================================
  Files        1619     1621       +2     
  Lines      155002   154643     -359     
  Branches     3985     4003      +18     
==========================================
- Hits        98572    98231     -341     
+ Misses      48659    48652       -7     
+ Partials     7771     7760      -11     
Flag Coverage Δ
frontend 53.14% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants