Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update logging dest #25473

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

harrisonravazzolo
Copy link
Member

No description provided.

Copy link
Contributor

@edwardsb edwardsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rfairburn
Copy link
Contributor

This will need a 2-stage deployment. The first will be to update the module changed here as a deployment. The second is we have to update the fleet_config to take an output for the extra IAM policies for external firehose.

I think I can still get this done sometime this evening during off hours.

@rfairburn
Copy link
Contributor

Is this intended to be a permanent change? And are we ok with the s3 buckets in the local dogfood account being deleted? I am ok if-so, but I wanted to make sure before applying the change, since this would be a consequence.

@allenhouchins
Copy link
Member

Is this intended to be a permanent change? And are we ok with the s3 buckets in the local dogfood account being deleted? I am ok if-so, but I wanted to make sure before applying the change, since this would be a consequence.

@rfairburn Our intent would be to make this a permanent change. That way the data is being sent to an environment that is more persistent, and managed more like how a customer would be managing this -- and giving access to whatever engineers need to look at things. We will then build dashboards off this data to showcase to customers, prospects, and internally.

I don't know who, if anyone, is looking at the data in the current S3 buckets. Which is part of what we're looking to fix...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants