Set correct default webhook batch size #25529
Open
+43
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the default webhook host batch size to align with the documentation, which states that:
Currently we're explicitly setting the batch size to
len(hosts)
i.e. "send a batch with all host IDs". This PR sets the batch size to 1 if it's set to 0 in the config, which results in one webhook request at a time.Note that with this change, there's no consistent way to return to the previous behavior of "send all host IDs" other than just setting a very high number for
host-batch-size
in the config. One option would be to interprethost-batch-size: -1
as "send all".