Chore rework UI activities #25539
Open
Chore rework UI activities #25539
+922
−770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For #23912 Add the ability to cancel upcoming activities in the UI. This adds that functionality but also changes the design of the activities used on the past and upcoming feeds. This PR includes: **new UI for activities on past and upcoming activity feeds **  **ability to cancel an upcoming activity**  **changes to the global activities to use the new activity behaviour and styles:**  > NOTE: there will need to be more work done to integrate with the API when this is ready. That will be done in another PR. - [ ] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. - [ ] Added/updated automated tests - [x] Manual QA for all new/changed functionality
relates to #23912 This renders the fleet avatar if the activity is fleet initiated  - [ ] Added/updated automated tests - [ ] Manual QA for all new/changed functionality
ghernandez345
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25539 +/- ##
==========================================
- Coverage 63.59% 63.58% -0.01%
==========================================
Files 1619 1621 +2
Lines 155002 155033 +31
Branches 3985 4051 +66
==========================================
+ Hits 98572 98583 +11
- Misses 48659 48679 +20
Partials 7771 7771
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ghernandez345
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
jacobshandling
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #23912
new UI for activities on the global, past, and upcoming feeds. These are the same changes in this PR, except we are reverting the changes around fleet initiated activities as that is not in the current activities API.
We are doing this so that the new activities can go out in a release while the backend is still being built and will be ready later.
changes/,orbit/changes/oree/fleetd-chrome/changes.