Edible Scripts Backend

[dantecatalfamo]

#24602

• Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  See Changes files for more information.
• Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
• Added/updated automated tests

[codecov]

Codecov Report

Attention: Patch coverage is 57.14286% with 48 lines in your changes missing coverage. Please review.

Project coverage is 63.58%. Comparing base (ff43593) to head (306f1f1).
Report is 84 commits behind head on main.

Files with missing lines	Patch %	Lines
server/service/scripts.go	53.33%	29 Missing and 13 partials ⚠️
server/datastore/mysql/scripts.go	71.42%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #25739      +/-   ##
==========================================
- Coverage   63.59%   63.58%   -0.01%     
==========================================
  Files        1622     1625       +3     
  Lines      155023   155573     +550     
  Branches     3967     3967              
==========================================
+ Hits        98580    98923     +343     
- Misses      48662    48834     +172     
- Partials     7781     7816      +35     

Flag	Coverage Δ
backend	64.44% <57.14%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[georgekarrv]

Sounds delicious 🍰

[sgress454]

Do we typically require the entity ID to be part of the body in a PATCH request? It's already present in the URL.

[dantecatalfamo]

I don't think so, I'll take another look at this

[sgress454]

Tested 👍 , code and tests look good, just the one question about requiring script ID in the body.

[dantecatalfamo]

@sgress454 Looks like it wasn't even needed, I wasn't sure if URL decoding was handled when we do a custom DecodeRequest

[dantecatalfamo]

Tests failing, maybe I'll have to add it back

[sgress454]

Tested 👍