Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: VPP app editing functionality #25860

Merged
merged 12 commits into from
Jan 30, 2025
Merged

Conversation

jahzielv
Copy link
Contributor

@jahzielv jahzielv commented Jan 29, 2025

For #24557

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated automated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 71.87500% with 27 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat-vpp-apps-labels@284dff7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
ee/server/service/vpp.go 69.56% 14 Missing and 7 partials ⚠️
server/service/vpp.go 60.00% 6 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             feat-vpp-apps-labels   #25860   +/-   ##
=======================================================
  Coverage                        ?   63.60%           
=======================================================
  Files                           ?     1625           
  Lines                           ?   155682           
  Branches                        ?     4025           
=======================================================
  Hits                            ?    99019           
  Misses                          ?    48846           
  Partials                        ?     7817           
Flag Coverage Δ
backend 64.45% <71.87%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jahzielv jahzielv changed the title 24557 vpp edit 3 feat: VPP app editing functionality Jan 29, 2025
@jahzielv jahzielv marked this pull request as ready for review January 29, 2025 22:29
@jahzielv jahzielv requested review from rachaelshaw and a team as code owners January 29, 2025 22:29
ee/server/service/vpp.go Outdated Show resolved Hide resolved
ee/server/service/vpp.go Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
server/fleet/activities.go Outdated Show resolved Hide resolved
server/fleet/activities.go Show resolved Hide resolved
server/fleet/activities.go Outdated Show resolved Hide resolved
Copy link
Member

@iansltx iansltx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick feedback loops here.

@jahzielv jahzielv merged commit cb0691b into feat-vpp-apps-labels Jan 30, 2025
34 checks passed
@jahzielv jahzielv deleted the 24557-vpp-edit-3 branch January 30, 2025 02:28
@jahzielv
Copy link
Contributor Author

Merged as docs checks can happen on merge to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants