-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upcoming Queue: fix the last few todos (groupwise-max queries) #26107
Merged
mna
merged 12 commits into
feat-upcoming-activites-queue
from
mna-23916-fix-last-todos-13
Feb 10, 2025
Merged
Upcoming Queue: fix the last few todos (groupwise-max queries) #26107
mna
merged 12 commits into
feat-upcoming-activites-queue
from
mna-23916-fix-last-todos-13
Feb 10, 2025
+122
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat-upcoming-activites-queue #26107 +/- ##
=================================================================
- Coverage 63.86% 63.85% -0.01%
=================================================================
Files 1632 1632
Lines 157875 157852 -23
Branches 4120 4093 -27
=================================================================
- Hits 100820 100792 -28
- Misses 49153 49155 +2
- Partials 7902 7905 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
gillespi314
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #23916 , follow-up of PR comments on #26067 and others.
Checklist for submitter
SELECT *
is avoided, SQL injection is prevented (using placeholders for values in statements)