Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming Queue: fix the last few todos (groupwise-max queries) #26107

Merged
merged 12 commits into from
Feb 10, 2025

Conversation

mna
Copy link
Member

@mna mna commented Feb 5, 2025

For #23916 , follow-up of PR comments on #26067 and others.

Checklist for submitter

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated automated tests

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.85%. Comparing base (194db62) to head (3cba03a).
Report is 1 commits behind head on feat-upcoming-activites-queue.

Additional details and impacted files
@@                        Coverage Diff                        @@
##           feat-upcoming-activites-queue   #26107      +/-   ##
=================================================================
- Coverage                          63.86%   63.85%   -0.01%     
=================================================================
  Files                               1632     1632              
  Lines                             157875   157852      -23     
  Branches                            4120     4093      -27     
=================================================================
- Hits                              100820   100792      -28     
- Misses                             49153    49155       +2     
- Partials                            7902     7905       +3     
Flag Coverage Δ
backend 64.70% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mna mna marked this pull request as ready for review February 10, 2025 13:37
@mna mna requested a review from a team as a code owner February 10, 2025 13:37
@mna mna merged commit 81f76d3 into feat-upcoming-activites-queue Feb 10, 2025
29 checks passed
@mna mna deleted the mna-23916-fix-last-todos-13 branch February 10, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants