add examples for submitting assemblies and parts #381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added strucuture and interface for Simulation object update design with some grouping and renaming, added user_stories to fill in Added example FORMAT Added the diagram Added stripped Flow360BaseModel Removed allow_but_remove WIP on updating the BaseModel to pydantic V2 WIP Add more docstring for details * Updated the base model to V2 in simulation * Fix unit test * Lint * fresh install * Add CI to UnderConstruction/SimulationInterface * Try again * Try again * Try again --------- Co-authored-by: benflexcompute <[email protected]>
* added geometry api * address comments
* Added meshing Param * remove temp file * Finished field population, will refine tomorrow * Added more examples * Changed models according to discussion. Will change examples now * Applied the suggestions to examples too * More example fixes * Fix more examples * Removed Simulation class
comments addressed lint print version of isort
* Entities implementation completed. The rest of relevant work is how and when _expand_entities function is called Created folder for new tests Removed ambiguity in implementation Fix format Applied Maciej's suggestion, trying to abstract it now Added EntityList Added default expansion to all entities Added input validation and more unit tests None input validation * Removed the use of global registry * Raise error when valid_types is None * Removed comments and unnecessary comment * comments addressed * Address final decorator comment * Fix unit test
* [ModelRef] Added Field Definitions for **UserDefinedDynamics** format * Update
…fault for it when EntityList is not required (#277)
* [ModelRef] Added Field Definitions for Outputs Removed test artifacts Fix format * Added Entity Implementation * Comments addressed * Fix unit test * Addressed comments * Fix unit test?
* basic support for pydantic v2 supported in unit system * implemented pydantic v2 support for unit system constrained types * attempt to use json encoders for unyt quantities * WIP - Splitting unit system implementations, supporting unit system in pydantic 2 * WIP - Fix runtime errors after pydantic v2 migration, fix tests * Fixed serialization issues * Fix schema issues and tests * Test fixes * Style fixes * Migrate Axis and Vector types to support pydantic v2, remove pd1-specific types from type definitions * Remove print statements and leftover code from legacy unit system class * Fix temperature type validator in pydantic v2 version --------- Co-authored-by: Andrzej Krupka <[email protected]>
* [ModelRef] Added Field Definitions for **TimeStepping** Comments addressed * Comments addressed * Update default
* [ModelRef] Added Field Definitions for **ReferenceGeometry** * added some thoughts in docstring * Fix unit test
* create surface mesh from geometry id * remove _0 in the naming * rename an example file * address comments * address comments * fix key in Cylinder class * fix path of resources in examples * remove dev env settting; keep geometry file name in remote * added preprod env handling (#282) Co-authored-by: Feilin <[email protected]> * use dev in geometry example * address comments * fix surface mesh cylinder from 3rd party * remove iges support --------- Co-authored-by: Maciej Skarysz <[email protected]>
* Add operating condition Rename some fields Add external flow operating condition Update design with from* methods Testing * Update example * Remove ExternalFlow and add AerospaceCondition * Add property for mach and rename ThermalCondition to ThermalState
* Add surface models Update freestream Adds turbulenceQuantities Address comments Move velcity type definition to operating_condition Address comments Address comments * Add restrictions * removed unused inflow model config --------- Co-authored-by: Maciej Skarysz <[email protected]>
* WIP * Volume model implementation Implement solver_numerics lint Implement material Fix unit test * Address comments * Address comments * Add initial condition * Add material constants as property * removed radius from BET disk as this is now part of entities --------- Co-authored-by: Yifan Bai <[email protected]> Co-authored-by: Maciej Skarysz <[email protected]>
* [ModelRef] Add Field Definitions for **MeshingParameters** Format * Refactored after reviewing the design on the notion page * Refactored after reviewing the design on the notion page-2 * Merged two edge type into one * Comments addressed * Corrected Docstring
* Fixed 500 reponses * Fix linting
…SimulationInterface
* now self review * Added suppport of GhostSurface in the post processings, and also changed some entity design * Moving things around and add test for updating with volume meshing metadata * Self reviewed * Reverted the entities change for RotationCylinder and added the AutomatedFarfield to shcema generator * comments addressed * Rename asset_entity_registy to just registry
* improved check on unit parser * added error message match to test
Rebase, was working on surface_meshing_translator line 128 Translator for surface meshing should be good. See if any more unit test needed Need to rebase Need to rebase again.. see github page Unit test passed, now self review Finished self review Revert to use entitylist for RotationCylinder Fix lint Update flow360/component/simulation/meshing_param/volume_params.py Co-authored-by: Maciej Skarysz <[email protected]>
* added default meshing to init service * addressed comments * unit test fix * addressed comment
* added units to actuator disk * added test for solver translator * added solver translator test * fixed pylint * fixed docstring
* Add actuator disk translator * Decouple model and solver json for BET
* Removed skipping defaults when getting a setting * Removed unused func
* Added validation of reusing cylinders in meshing * Fix unit test * Comment addressed
* Work around for inconsistent zone name from meshers (#360) fixed comparing to not None in if statements (#362) Remove reference geometry default from translator (#359) Add actuator disk translator (#361) * Add actuator disk translator * Decouple model and solver json for BET Add CHT unit test Add heat transfer zone translator Handle solid wall boundaries Fix pylint and unit tests Add initial condition in translator start adding vortexPropagation converter test vortexPropagation passes. Waiting for periodic boundary implementationn for periodicEulerVortex Add periodic boundary translator periodicVortex passes Address comments * Improve error message * Remove unused function --------- Co-authored-by: Ben <[email protected]>
* TMP * Fixed issue with not having discriminator for turbulenceQuantities * Removed print
feilin-flexcompute
force-pushed
the
feilin/geoIntegration_v2
branch
from
1f4149d to
e417d3b
Compare
Base automatically changed from
UnderConstruction/SimulationInterface
to
develop
August 2, 2024 14:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready