Skip to content

Conversation

@dbochkov-flexcompute
Copy link
Contributor

@dbochkov-flexcompute dbochkov-flexcompute commented Apr 4, 2025

Copy link
Contributor

@dmarek-flex dmarek-flex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I just went through and found a few typos.

description="Spatial distribution of the magnetic field on the internal and external sides of the surface.",
)

normal: TriangularSurfaceDataset = pd.Field(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please clarify if this points outwards for closed surfaces. Also, will this work for an open surface (2D PEC)?

f"{self._values_coords_dict} before plotting."
)

# compute max magnitude of vecotr field
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

... start=1e-13,
... stop=5e-13,
... interval=2,
... name='movie_monitor')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change name

UnstructuredGridDataset
Data after reflextion is performed.
UnstructuredDataset
Dataset after reflextion is performed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@dbochkov-flexcompute
Copy link
Contributor Author

closed in favor of #2891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants