Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 17 to 19 #2495

Merged

Conversation

julien-louis
Copy link
Collaborator

@julien-louis julien-louis commented Nov 8, 2024

devs may need to update node and/or npm

#2387

@pierrehenri-dauvergne
Copy link
Collaborator

I have this error when deploying front-dev:
An unhandled exception occurred: Cannot find module @rollup/rollup-linux-x64-musl. npm has a bug related to optional dependencies (npm/cli#4828). Please try npm i again after removing both package-lock.json and node_modules directory.

I tried most of the proposed solution in the thread but none worked. It's opened for 2 years and it's still an issue. I'm not quite sure what to do.

@julien-louis
Copy link
Collaborator Author

julien-louis commented Nov 26, 2024 via email

@pierrehenri-dauvergne
Copy link
Collaborator

On the thread's issue, someone says that windows users should add this in package.json:

"os": [
    "win32",
    "linux"
],
"optionalDependencies": {
    "@lmdb/lmdb-linux-x64": "^3.0.13",
    "@lmdb/lmdb-win32-x64": "^3.0.13",
    "@rollup/rollup-win32-x64-msvc": "4.22.4",
    "@rollup/rollup-linux-x64-gnu": "4.22.4"
},

I try but it didn't change anything. I also tried with only windows lines but the error didn't change.

@julien-louis julien-louis force-pushed the angular-17-to-18-novite branch from 1b837b5 to 2ad2b72 Compare December 3, 2024 14:20
@julien-louis
Copy link
Collaborator Author

@pierrehenri-dauvergne I upgraded to angular 19 and the annoying dependencies are no longer needed

@julien-louis julien-louis changed the title Angular 17 to 18 novite Angular 17 to 19 Dec 3, 2024
@michaelkain
Copy link
Contributor

Hi! to merge before test session?

Copy link
Collaborator

@pierrehenri-dauvergne pierrehenri-dauvergne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it work, i had to use "FROM node:lts-alpine as front-dev" in Dockerfile, it uses node v23.3.0

EDIT: Tested some more locally and had no issue, I'm merging

@pierrehenri-dauvergne pierrehenri-dauvergne merged commit 854ffe0 into fli-iam:develop Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants