-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 17 to 19 #2495
Angular 17 to 19 #2495
Conversation
I have this error when deploying front-dev: I tried most of the proposed solution in the thread but none worked. It's opened for 2 years and it's still an issue. I'm not quite sure what to do. |
Pierre Henry,
Je crois que tu dois ajouter la dependence version windows à la suite de celle-ci.
Julien
… De: "pierrehenri-dauvergne" ***@***.***>
À: "fli-iam" ***@***.***>
Cc: "Julien Louis" ***@***.***>, "Author" ***@***.***>
Envoyé: Vendredi 22 Novembre 2024 17:17:59
Objet: Re: [fli-iam/shanoir-ng] Angular 17 to 18 novite (PR #2495)
I have this error when deploying front-dev:
An unhandled exception occurred: Cannot find module
@rollup/rollup-linux-x64-musl. npm has a bug related to optional dependencies (
[ npm/cli#4828 | npm/cli#4828 ] ). Please try npm i
again after removing both package-lock.json and node_modules directory.
I tried most of the proposed solution in the thread but none worked. It's opened
for 2 years and it's still an issue. I'm not quite sure what to do.
—
Reply to this email directly, [
#2495 (comment) | view
it on GitHub ] , or [
https://github.com/notifications/unsubscribe-auth/AFBXXF3GJUTG3FQFXHWTU432B5KLPAVCNFSM6AAAAABRNXH7OSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJUGEZTGOJVHE
| unsubscribe ] .
You are receiving this because you authored the thread. Message ID:
***@***.***>
|
On the thread's issue, someone says that windows users should add this in package.json:
I try but it didn't change anything. I also tried with only windows lines but the error didn't change. |
1b837b5
to
2ad2b72
Compare
@pierrehenri-dauvergne I upgraded to angular 19 and the annoying dependencies are no longer needed |
Hi! to merge before test session? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it work, i had to use "FROM node:lts-alpine as front-dev" in Dockerfile, it uses node v23.3.0
EDIT: Tested some more locally and had no issue, I'm merging
devs may need to update node and/or npm
#2387