Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add smtp configuration options in env file #2503

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

add smtp configuration options in env file #2503

wants to merge 5 commits into from

Conversation

AxelCouturierCIBM
Copy link

No description provided.

@michaelkain michaelkain requested a review from a-ba November 15, 2024 10:38
a-ba
a-ba requested changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@a-ba a-ba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for most parts.

These changes also need to be applied in the keycloak configuration in:

  • docker-compose/keycloak/cfg/shanoir-ng-realm.json
  • docker-compose/keycloak/entrypoint

@michaelkain
Copy link
Contributor

Hi @a-ba, I hope you are doing fine.
If all is fine with this PR, I think it would be great to approve it please, that we can merge it.
Thank you and with kind regards, Michael

@michaelkain
Copy link
Contributor

Hi @AxelCouturierCIBM, I hope you are doing great.
A big thank you for your contribution! We keep in touch.
With kind regards, Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-ba a-ba a-ba requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@a-ba a-ba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AxelCouturierCIBM @michaelkain @a-ba