Change structure to separate application from library #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move application to cmd/main.go and update documentation Move a few things into library code and name it a new package "tileutils"
polastre
approved these changes
May 17, 2024
| @@ -1,13 +1,13 @@ | |||
| package main | |||
| package tileutils | |||
There was a problem hiding this comment.
technically this package should be called baremaps-exporter. If we are going to call this tileutils we should probably put it in a pkg/tileutils directory to follow golang name standards.
There was a problem hiding this comment.
I wanted a one word name, so I moved it to pkg/tileutils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move application to cmd/main.go and update documentation
Move a few things into library code and name it a new package "tileutils"
Update to setup-go action is included to resolve GitHub complaining about deprecated nodejs version used by this action.