Skip to content

Commit

Permalink
Use .json for base extension is s3 exporter
Browse files Browse the repository at this point in the history
  • Loading branch information
Garrett McGrath committed Dec 20, 2023
1 parent 5b43d11 commit 98f1a80
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions per-message-s3-exporter/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -329,10 +329,11 @@ def _s3_bucket_folder(self) -> str:

def _s3_file_extension(self) -> str:
"""File extension to use for uploads to S3"""
base_extension = ".json"
if self.compression_type == "none":
return ""
return base_extension

return ".bz2"
return f"{base_extension}.bz2"

def batch_filename(self) -> str:
"""Filename to use in S3 for writing out the Firehose messages"""
Expand Down

0 comments on commit 98f1a80

Please sign in to comment.