Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Positive * pos_inf should be pos_inf, not 0 +- inf. Same for other combinations of signs. #409

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Positive * pos_inf should be pos_inf, not 0 +- inf. Same for other combinations of signs. #409

merged 2 commits into from
Mar 25, 2022

Conversation

postmath
Copy link
Contributor

This addresses github issue #408.

@fredrik-johansson
Copy link
Collaborator

Thanks! Just two changes:

  • Move these branches below ARB_IS_LAGOM(...). These are fast paths for regular arithmetic and exclude infinities.
  • Add some test code (does not need to be randomized tests; you can just test the relevant special cases).

@postmath
Copy link
Contributor Author

Thanks for the review.

@fredrik-johansson fredrik-johansson merged commit ab5e81c into flintlib:master Mar 25, 2022
@fredrik-johansson
Copy link
Collaborator

Looks great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@postmath @fredrik-johansson