Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tribonacci #42

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Tribonacci #42

wants to merge 7 commits into from

Conversation

raoulb
Copy link

@raoulb raoulb commented Sep 18, 2022

Implementation of the Tribonacci constant via radicals.

@fredrik-johansson
Copy link
Collaborator

I think ca_tribonacci_constant should just create an element of the simple number field generated by qqbar_tribonacci_constant.

Other than that it looks good.

@raoulb
Copy link
Author

raoulb commented Sep 28, 2022

I considered that, too. But then I modeled Tc in analogy to the golden ratio.
With my latest commit, it should be fine now.

Instead of the old output:

Evaluating Tc as ca:
1.83929 {(a+b+1)/3 where a = 3.30906 [Pow(36.2337 {3*c+19}, 0.333333 {1/3})], b = 1.20880 [Pow(1.76631 {-3*c+19}, 0.333333 {1/3})], c = 5.74456 [c^2-33=0]}

the example code now gives:

Evaluating Tc as ca:
1.83929 {a where a = 1.83929 [a^3-a^2-a-1=0]}

which at least looks much more useful indeed.

@raoulb
Copy link
Author

raoulb commented Sep 28, 2022

In case of the golden ratio, the expression in terms of radicals is much simpler than here and hence the difference between both representations probably not such a big deal. What do you think, should we represent it as element of Q[a] where a^2 - a - 1 = 0?

I probably do not see through the details and consequences to really judge.
My main argument might just be for the sake of consistency.

BTW: I could try to do the changes if you agree.

@raoulb raoulb force-pushed the tribonacci branch 2 times, most recently from 7674bb3 to 116910e Compare September 28, 2022 03:04
Raoul Bourquin added 2 commits October 29, 2022 00:13
The `ca_tribonacci_constant` just creates an element of the simple
number field generated by `qqbar_tribonacci_constant`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants