[WIP] Pointers #1084
Closed
[WIP] Pointers #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to better comply with GMP and to not get warnings when
compiling, change the array-type inputs to pointers. Here the earlier
types where changed by
_aprcl_config -> aprcl_config_struct
aprcl_config -> aprcl_config_t
and new types where introduced:
aprcl_config_ptr = aprcl_config_struct *
aprcl_config_srcptr = const aprcl_config_struct *
Analogue changes were made to unity_zp[q].
Thus, the following types were added
d_mat_ptr = d_mat_struct *
d_mat_srcptr = const d_mat_struct *
Changed
flint_rand_s -> flint_rand_struct
and introduced the new types
flint_rand_ptr = flint_rand_struct *
flint_rand_srcptr = const flint_rand_struct *
Changed the whole n_factor to pointer based, as it was not pointer based
earlier. Thus, the following types were introduced:
n_factor_struct
n_factor_t = n_factor_struct[1]
n_factor_ptr = n_factor_struct *
n_factor_srcptr = const n_factor_struct *
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very descriptive title. Basically I am trying to make pointer types for (almost) every type in FLINT such that #1079 can be solved.
I also aim to make the types in FLINT more coherent. Not only within the repository, but also with GMP. For examples within FLINT, we have
n_factor_twhich at the moment is not a one-element array, but a struct. Very confusing. Also, the types inapcrlis named different compared to all the other parts in FLINT.I do not aim to simply change everything. I still think that the documentation should try to involve types such as
fmpz_tinstead offmpz_ptrfor the sake of not involving too many types in the documentation, but the actual declarations should have the pointer versions in order to not get warnings from GCC about overreadings; At least when things are on the formconst mystruct[1], but the other variants should change as well for the sake of coherency.I know this has not really been discussed yet, but I think it is the way to go.
For specific namings schemes, please see the commit messages.