Fix division by zero in monomials_deflate.c
.
#2066
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for
fmpz_mpoly_deflate
(and similar) statesThe previous comment and if-statement did not align, meaning that the denominator was not being checked leading to divisions by zero when
stride[v]
is 0.Here is a MWE
Without this patch:
With:
From python-flint here: flintlib/python-flint#216 (comment)