Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements & fixes to api deadlines & task timeouts #33

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Improvements & fixes to api deadlines & task timeouts #33

wants to merge 5 commits into from

Conversation

aakash-fk
Copy link
Contributor

No description provided.

@aakash-fk aakash-fk force-pushed the deadline-timeout-improve branch from 4c8d714 to 88dd7f6 Compare May 2, 2021 17:32
ToOnlyGaurav
ToOnlyGaurav requested changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@ToOnlyGaurav ToOnlyGaurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.
Possible to add test cases as well.

@aakash-fk
Copy link
Contributor Author

Working on tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ToOnlyGaurav ToOnlyGaurav ToOnlyGaurav requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aakash-fk @ToOnlyGaurav