-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ranger server [Dependent on PR #42, #43] #44
Conversation
… ListBasedServiceRegistry along with the MapBased one 1) Added a criteria interface in the ShardSelector to keep it seperate from the T in ServiceNode and trickled the changes upstream to whereever ShardSelector is getting built. 2) Added test cases to the new criteria interface 3) Added Http serivceNodeProvider and serviceFinders, along with the HttpServiceFinderHub 4) Added tests for Http interfaces as well. 5) Added license to the missing files 6) Fixed sonar issues
…for when it has to be latter passed down as an arg to a function. b) .equalsIgnoreCase in selector tests has crept in during the previous sonar lints, corrected the same. c) Addressed sonar lint issues on license block
…rce formatting c) Reverted the version change to have the APIs begin with a version
…ctions and added http and zk clients respectively with required test cases. This will help end-clients not replicate the same boiler plate code again and again
…an be used across for various modules
… working server with a NodeData in ranger-server
…rces to provide default empty list in response
…p a bunch of ranger http providers. WIP version #0
…server to denote that zk is the backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only done partially.
ranger-client/src/test/java/com/flipkart/ranger/client/stubs/RangerTestHub.java
Show resolved
Hide resolved
ranger-client/src/main/java/com/flipkart/ranger/client/RangerHubClient.java
Outdated
Show resolved
Hide resolved
ranger-client/src/main/java/com/flipkart/ranger/client/RangerClient.java
Outdated
Show resolved
Hide resolved
ranger-zk-server/src/main/java/com/flipkart/ranger/server/manager/RangerBundleManager.java
Outdated
Show resolved
Hide resolved
...er-zookeeper/src/main/java/com/flipkart/ranger/zookeeper/servicefinder/ZkNodeDataSource.java
Outdated
Show resolved
Hide resolved
b) Fixed minor formatting issues c) Fixed the error logging in ZkNodeDataSource and removed the unnecessary throw illegalState
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pass2
...er-http-client/src/main/java/com/flipkart/ranger/client/http/ShardedRangerHttpHubClient.java
Show resolved
Hide resolved
...va/com/flipkart/ranger/core/finder/serviceregistry/signal/ScheduledRegistryUpdateSignal.java
Show resolved
Hide resolved
ranger-core/src/main/java/com/flipkart/ranger/core/finder/SimpleUnshardedServiceFinder.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/flipkart/ranger/core/healthservice/monitor/sample/RotationStatusMonitor.java
Outdated
Show resolved
Hide resolved
ranger-core/src/main/java/com/flipkart/ranger/core/finderhub/ServiceFinderHubBuilder.java
Outdated
Show resolved
Hide resolved
ranger-core/src/main/java/com/flipkart/ranger/core/model/Service.java
Outdated
Show resolved
Hide resolved
...-core/src/main/java/com/flipkart/ranger/core/serviceprovider/BaseServiceProviderBuilder.java
Outdated
Show resolved
Hide resolved
…se of failures. Fixed the same
…ll mutable types in the codebase
…case exec time from 3 minutes to 40 seconds
Removed the unnecessary error in GenericResponse
…g it for future, while not completely nailing down how a serviceProvider's errors may be manifested is not a good option, imo. In the case of a finderHub though, since there could be any of the hubs that may error out (and the errors are getting logged at the point whey they error out), one responseCode won't cut it. I don't think it is future provisioning as well, if anything this will hinder our ability to add proper error blocks in the future, when the need arises
@santanusinha : Please let me know if the travis builds are failing, I had run them on my travis-ci pipeline - multiple times to simulate the intermittent timing errors, with upper bounds [here]. Shouldn't be happening intermittently now. I have run them a bunch of times just to check/re-check. |
This is the third part of PR #41. This includes a ranger-server-bundle and an example ranger-server (atop ZK) which could potentially act as an http backend.
Replacing the data source is easy as building a hub. As further data sources come in, the recommendation is to first build the respective client modules [as submitted in #43] and then use a constructor builder to build the hub, instead of the boiler plate code.
Added tests for the ranger-server-bundle, along with a sample .yml config to help run the server quickly.