Skip to content

Commit

Permalink
Split to different modules (#91)
Browse files Browse the repository at this point in the history
**Background**

Now core package very huge and we want split it
  • Loading branch information
LionZXY authored Nov 1, 2021
1 parent 5206c17 commit 6965ea3
Show file tree
Hide file tree
Showing 106 changed files with 258 additions and 200 deletions.
2 changes: 1 addition & 1 deletion components/analytics/shake2report/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ plugins {
apply<com.flipperdevices.gradle.ConfigurationPlugin>()

dependencies {
implementation(project(":components:core"))
implementation(project(":components:core:ktx"))

implementation(Libs.ANNOTATIONS)
implementation(Libs.APPCOMPAT)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import com.flipperdevices.analytics.shake2report.Shake2Report
import com.flipperdevices.analytics.shake2report.Shake2ReportApi
import com.flipperdevices.analytics.shake2report.databinding.ActivityShake2reportBinding
import com.flipperdevices.analytics.shake2report.helper.Shake2ReportDialog
import com.flipperdevices.core.utils.toast
import com.flipperdevices.core.ktx.toast
import io.sentry.Attachment
import io.sentry.Sentry
import io.sentry.SentryEvent
Expand Down
File renamed without changes.
5 changes: 5 additions & 0 deletions components/bottombar/api/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
plugins {
id("com.android.library")
id("kotlin-android")
}
apply<com.flipperdevices.gradle.ConfigurationPlugin>()
1 change: 1 addition & 0 deletions components/bottombar/api/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<manifest package="com.flipperdevices.bottombar.api" />
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.flipperdevices.core.api
package com.flipperdevices.bottombar.api

/**
* Class which provide api to bottombar module
Expand Down
Empty file.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,13 @@ apply<com.flipperdevices.gradle.ConfigurationPlugin>()
apply<com.flipperdevices.gradle.ComposerPlugin>()

dependencies {
implementation(project(":components:core"))
implementation(project(":components:bottombar:api"))

implementation(project(":components:core:di"))
implementation(project(":components:core:navigation"))
implementation(project(":components:core:ui"))

implementation(project(":components:info:api"))
implementation(project(":components:pair:api"))
implementation(project(":components:filemanager:api"))

Expand All @@ -26,4 +32,6 @@ dependencies {
implementation(Libs.LIFECYCLE_RUNTIME_KTX)
implementation(Libs.LIFECYCLE_VIEWMODEL_KTX)
implementation(Libs.ACTIVITY_KTX)

implementation(Libs.CICERONE)
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.flipperdevices.bottombar">
package="com.flipperdevices.bottombar.impl">

<application>
<activity
android:launchMode="singleTop"
android:exported="false"
android:name="com.flipperdevices.bottombar.main.BottomNavigationActivity" />
android:launchMode="singleTop"
android:name=".main.BottomNavigationActivity" />
</application>
</manifest>
Original file line number Diff line number Diff line change
@@ -1,19 +1,20 @@
package com.flipperdevices.bottombar.api
package com.flipperdevices.bottombar.impl.api

import android.content.Context
import android.content.Intent
import android.content.Intent.FLAG_ACTIVITY_CLEAR_TASK
import android.content.Intent.FLAG_ACTIVITY_CLEAR_TOP
import android.content.Intent.FLAG_ACTIVITY_NEW_TASK
import com.flipperdevices.bottombar.main.BottomNavigationActivity
import com.flipperdevices.core.api.BottomNavigationActivityApi
import com.flipperdevices.bottombar.api.BottomNavigationActivityApi
import com.flipperdevices.bottombar.impl.main.BottomNavigationActivity
import com.flipperdevices.core.di.AppGraph
import com.squareup.anvil.annotations.ContributesBinding
import javax.inject.Inject

@ContributesBinding(AppGraph::class)
class BottomNavigationActivityApiImpl @Inject constructor(private val context: Context) :
BottomNavigationActivityApi {
class BottomNavigationActivityApiImpl @Inject constructor(
private val context: Context
) : BottomNavigationActivityApi {
override fun openBottomNavigationScreen() {
context.startActivity(
Intent(context, BottomNavigationActivity::class.java).apply {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package com.flipperdevices.bottombar.di
package com.flipperdevices.bottombar.impl.di

import com.flipperdevices.bottombar.main.BottomNavigationActivity
import com.flipperdevices.bottombar.main.TabContainerFragment
import com.flipperdevices.bottombar.impl.main.BottomNavigationActivity
import com.flipperdevices.bottombar.impl.main.TabContainerFragment
import com.flipperdevices.core.di.AppGraph
import com.squareup.anvil.annotations.ContributesTo

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.flipperdevices.bottombar.main
package com.flipperdevices.bottombar.impl.main

import android.os.Bundle
import androidx.activity.viewModels
Expand All @@ -8,11 +8,11 @@ import androidx.compose.ui.platform.ComposeView
import androidx.compose.ui.platform.ViewCompositionStrategy
import androidx.fragment.app.Fragment
import androidx.fragment.app.FragmentActivity
import com.flipperdevices.bottombar.R
import com.flipperdevices.bottombar.di.BottomBarComponent
import com.flipperdevices.bottombar.main.compose.ComposeBottomBar
import com.flipperdevices.bottombar.main.service.BottomNavigationViewModel
import com.flipperdevices.bottombar.model.FlipperBottomTab
import com.flipperdevices.bottombar.impl.R
import com.flipperdevices.bottombar.impl.di.BottomBarComponent
import com.flipperdevices.bottombar.impl.main.compose.ComposeBottomBar
import com.flipperdevices.bottombar.impl.main.service.BottomNavigationViewModel
import com.flipperdevices.bottombar.impl.model.FlipperBottomTab
import com.flipperdevices.core.di.ComponentHolder
import com.flipperdevices.core.navigation.delegates.OnBackPressListener
import com.github.terrakok.cicerone.Router
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
package com.flipperdevices.bottombar.main
package com.flipperdevices.bottombar.impl.main

import android.os.Bundle
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.fragment.app.Fragment
import com.flipperdevices.bottombar.R
import com.flipperdevices.bottombar.di.BottomBarComponent
import com.flipperdevices.bottombar.model.FlipperBottomTab
import com.flipperdevices.bottombar.navigate.ScreenTabProvider
import com.flipperdevices.bottombar.impl.R
import com.flipperdevices.bottombar.impl.di.BottomBarComponent
import com.flipperdevices.bottombar.impl.model.FlipperBottomTab
import com.flipperdevices.bottombar.impl.navigate.ScreenTabProvider
import com.flipperdevices.core.di.ComponentHolder
import com.flipperdevices.core.navigation.delegates.OnBackPressListener
import com.github.terrakok.cicerone.Navigator
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.flipperdevices.bottombar.main
package com.flipperdevices.bottombar.impl.main

import androidx.compose.foundation.background
import androidx.compose.foundation.border
Expand All @@ -9,7 +9,7 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.unit.dp
import com.flipperdevices.core.view.ComposeFragment
import com.flipperdevices.core.ui.ComposeFragment

class TestFragment : ComposeFragment() {
@Composable
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.flipperdevices.bottombar.main.compose
package com.flipperdevices.bottombar.impl.main.compose

import androidx.compose.material.BottomNavigation
import androidx.compose.material.BottomNavigationItem
Expand All @@ -8,7 +8,7 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.tooling.preview.Preview
import com.flipperdevices.bottombar.model.FlipperBottomTab
import com.flipperdevices.bottombar.impl.model.FlipperBottomTab

@Preview(
showBackground = true
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package com.flipperdevices.bottombar.main.service
package com.flipperdevices.bottombar.impl.main.service

import androidx.lifecycle.ViewModel
import androidx.lifecycle.viewModelScope
import com.flipperdevices.bottombar.model.FlipperBottomTab
import com.flipperdevices.bottombar.impl.model.FlipperBottomTab
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.launch
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package com.flipperdevices.bottombar.model
package com.flipperdevices.bottombar.impl.model

import androidx.annotation.DrawableRes
import androidx.annotation.StringRes
import com.flipperdevices.bottombar.R
import com.flipperdevices.bottombar.impl.R

/**
* Warning: this class is processed by Proguard
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package com.flipperdevices.bottombar.navigate
package com.flipperdevices.bottombar.impl.navigate

import com.flipperdevices.bottombar.model.FlipperBottomTab
import com.flipperdevices.bottombar.impl.model.FlipperBottomTab
import com.github.terrakok.cicerone.Screen

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
package com.flipperdevices.bottombar.navigate
package com.flipperdevices.bottombar.impl.navigate

import com.flipperdevices.bottombar.main.TestFragment
import com.flipperdevices.bottombar.model.FlipperBottomTab
import com.flipperdevices.bottombar.impl.main.TestFragment
import com.flipperdevices.bottombar.impl.model.FlipperBottomTab
import com.flipperdevices.core.di.AppGraph
import com.flipperdevices.core.navigation.screen.InfoScreenProvider
import com.flipperdevices.filemanager.api.navigation.FileManagerScreenProvider
import com.flipperdevices.info.api.screen.InfoScreenProvider
import com.github.terrakok.cicerone.Screen
import com.github.terrakok.cicerone.androidx.FragmentScreen
import com.squareup.anvil.annotations.ContributesBinding
Expand Down
21 changes: 0 additions & 21 deletions components/bottombar/proguard-rules.pro

This file was deleted.

1 change: 0 additions & 1 deletion components/bridge/api/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ plugins {
apply<com.flipperdevices.gradle.ConfigurationPlugin>()

dependencies {
implementation(project(":components:core"))
implementation(project(":components:bridge:protobuf"))

implementation(Libs.KOTLIN_COROUTINES)
Expand Down
4 changes: 3 additions & 1 deletion components/bridge/impl/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ plugins {
apply<com.flipperdevices.gradle.ConfigurationPlugin>()

dependencies {
implementation(project(":components:core"))
implementation(project(":components:core:log"))
implementation(project(":components:core:ktx"))

implementation(project(":components:bridge:api"))
implementation(project(":components:bridge:protobuf"))

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import com.flipperdevices.bridge.api.utils.Constants
import com.flipperdevices.bridge.impl.manager.delegates.FlipperConnectionInformationApiImpl
import com.flipperdevices.bridge.impl.manager.service.FlipperInformationApiImpl
import com.flipperdevices.bridge.impl.manager.service.FlipperSerialApiImpl
import com.flipperdevices.core.utils.newSingleThreadExecutor
import com.flipperdevices.core.ktx.newSingleThreadExecutor
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.asCoroutineDispatcher
import kotlinx.coroutines.flow.filter
Expand Down
1 change: 0 additions & 1 deletion components/bridge/protobuf/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ plugins {
apply<com.flipperdevices.gradle.ConfigurationPlugin>()

dependencies {
implementation(project(":components:core"))
api(Libs.PROTOBUF_JAVALITE)
api(Libs.PROTOBUF_KOTLIN) {
exclude(group = Libs.PROTOBUF_GROUP)
Expand Down
1 change: 0 additions & 1 deletion components/bridge/service/api/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ plugins {
apply<com.flipperdevices.gradle.ConfigurationPlugin>()

dependencies {
implementation(project(":components:core"))
implementation(project(":components:bridge:api"))

implementation(Libs.ANNOTATIONS)
Expand Down
6 changes: 5 additions & 1 deletion components/bridge/service/impl/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ plugins {
apply<com.flipperdevices.gradle.ConfigurationPlugin>()

dependencies {
implementation(project(":components:core"))
implementation(project(":components:core:di"))
implementation(project(":components:core:log"))
implementation(project(":components:core:preference"))

implementation(project(":components:bridge:api"))
implementation(project(":components:bridge:provider"))
implementation(project(":components:bridge:protobuf"))
implementation(project(":components:bridge:service:api"))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import com.flipperdevices.bridge.service.impl.delegate.FlipperServiceConnectDele
import com.flipperdevices.bridge.service.impl.di.FlipperServiceComponent
import com.flipperdevices.bridge.service.impl.provider.error.FlipperServiceErrorListener
import com.flipperdevices.core.di.ComponentHolder
import com.flipperdevices.core.utils.preference.FlipperSharedPreferencesKey
import com.flipperdevices.core.preference.FlipperSharedPreferencesKey
import javax.inject.Inject
import kotlinx.coroutines.TimeoutCancellationException
import kotlinx.coroutines.launch
Expand Down
Empty file removed components/core/consumer-rules.pro
Empty file.
File renamed without changes.
5 changes: 5 additions & 0 deletions components/core/di/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
plugins {
id("com.android.library")
id("kotlin-android")
}
apply<com.flipperdevices.gradle.ConfigurationPlugin>()
1 change: 1 addition & 0 deletions components/core/di/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<manifest package="com.flipperdevices.core.di" />
1 change: 1 addition & 0 deletions components/core/ktx/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/build
9 changes: 9 additions & 0 deletions components/core/ktx/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
plugins {
id("com.android.library")
id("kotlin-android")
}
apply<com.flipperdevices.gradle.ConfigurationPlugin>()

dependencies {
implementation(Libs.APPCOMPAT)
}
1 change: 1 addition & 0 deletions components/core/ktx/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<manifest package="com.flipperdevices.core.ktx" />
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.flipperdevices.core.utils
package com.flipperdevices.core.ktx

import java.util.concurrent.Executor
import java.util.concurrent.Executors
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.flipperdevices.core.utils
package com.flipperdevices.core.ktx

import android.os.Bundle
import androidx.fragment.app.Fragment
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.flipperdevices.core.utils
package com.flipperdevices.core.ktx

import android.content.Context
import android.widget.Toast
Expand Down
1 change: 1 addition & 0 deletions components/core/log/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/build
9 changes: 9 additions & 0 deletions components/core/log/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
plugins {
id("com.android.library")
id("kotlin-android")
}
apply<com.flipperdevices.gradle.ConfigurationPlugin>()

dependencies {
api(Libs.TIMBER)
}
1 change: 1 addition & 0 deletions components/core/log/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<manifest package="com.flipperdevices.core.log" />
1 change: 1 addition & 0 deletions components/core/navigation/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/build
17 changes: 17 additions & 0 deletions components/core/navigation/build.gradle.kts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
plugins {
id("com.android.library")
id("kotlin-android")
id("com.squareup.anvil")
id("kotlin-kapt")
}
apply<com.flipperdevices.gradle.ConfigurationPlugin>()

dependencies {
implementation(project(":components:core:di"))

implementation(Libs.CICERONE)

// Dagger deps
implementation(Libs.DAGGER)
kapt(Libs.DAGGER_COMPILER)
}
1 change: 1 addition & 0 deletions components/core/navigation/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<manifest package="com.flipperdevices.core.navigation" />
1 change: 1 addition & 0 deletions components/core/preference/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/build
Loading

0 comments on commit 6965ea3

Please sign in to comment.