[DRAFT] Migrate update to new BLE api #1008
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makeevrserg
commented
Dec 27, 2024
| BatteryState.Ready(gattInfo.isCharging, batteryLevel) | ||
| } ?: BatteryState.Unknown | ||
| } | ||
| }.stateIn(viewModelScope, SharingStarted.Lazily, BatteryState.Unknown) |
There was a problem hiding this comment.
Need to be lazily because we can't properly mock FGattInfoFeatureApi without it
makeevrserg
commented
Dec 27, 2024
| @@ -124,6 +136,9 @@ class UpdateRequestViewModelTest { | |||
| @Test | |||
| fun `Open update request with sync`() = runTest { | |||
| synchronizationState.emit(SynchronizationState.InProgress.Default(0f)) | |||
| viewModel.getBatteryState() | |||
There was a problem hiding this comment.
It's required to call batteryState initialization. It's lazy initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Migration of all update modules into new api
Changes
Test plan
TODO