Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug with reading pwd locked MFULs #3959

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Fixed bug with reading pwd locked MFULs #3959

merged 5 commits into from
Oct 31, 2024

Conversation

mishamyte
Copy link
Contributor

@mishamyte mishamyte commented Oct 17, 2024 •
edited by skotopes
Loading

What's new

  • Changed reading of MFUL tags. Now read is performed by 1 block at a time for getting a NACK on a correct block.

For reviewers: no variable names or data structures were changes as a part of that PR. If needed, pls lemme know.

Verification

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

RebornedBrain
RebornedBrain reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@RebornedBrain RebornedBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, will be merged after qa

RebornedBrain
RebornedBrain reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@RebornedBrain RebornedBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine

skotopes
skotopes previously approved these changes Oct 31, 2024
View reviewed changes
@mishamyte
Copy link
Contributor Author

Thx for validation, keeping branch up to date & formatting <3

@skotopes skotopes merged commit 4b8a1a4 into flipperdevices:dev Oct 31, 2024
11 checks passed
@mishamyte mishamyte deleted the bug/read-of-locked-mful branch October 31, 2024 16:12
RogueMaster pushed a commit to RogueMaster/flipperzero-firmware-wPlugins that referenced this pull request Nov 2, 2024
@mishamyte @skotopes @RogueMaster
Fixed bug with reading pwd locked MFULs (flipperdevices#3959)
dc97b93 
* Fixed bug with reading pwd locked MFULs
* Format sources

Co-authored-by: あく <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RebornedBrain RebornedBrain RebornedBrain left review comments

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra Astrrra is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mishamyte @skotopes @RebornedBrain