go cleanup memory after use #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lol oh now I see this was on top of #151 . will get that into a reviewable state tonight |
|
FFI is a challenge and there is a lot of hidden gems :( |
markphelps
added a commit
that referenced
this pull request
Feb 29, 2024
…-sdks into list-flags * 'list-flags' of https://github.com/flipt-io/flipt-client-sdks: cleanup memory after use (#154)
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
* feat(wip): remove passing array of namespace everywhere * chore: fmt * feat(wip): return flags list * chore: add basic test * chore: rm namespace from requests * chore: simplify * chore: fix ruby client/test * chore: java client * chore: fmt java * chore: try to add list_flags to node * chore: try to ignore unknown flag type property * chore: try to fix node test * cleanup memory after use (#154) * chore: python cleanup * chore: fix python; test * chore: go list flags * chore: fix rust test * chore: PR suggestions --------- Co-authored-by: Roman Dmytrenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://go.dev/blog/cgo#strings-and-things