Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/Package #39

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Build/Package #39

merged 5 commits into from
Dec 21, 2023

Conversation

markphelps
Copy link
Contributor

@markphelps markphelps commented Dec 20, 2023

Re: #38

First steps in packaging natively per ecosystem

This creates a dagger pipeline to build packages for each ecosystem.

It currently assumes that the built libraries for each arch/platform exist locally in the following structure

tmp
├── darwin_arm64
│   └── libfliptengine.dylib
├── flipt_engine.h
├── linux_arm64
│   └── libfliptengine.so
└── linux_x84_64
    └── libfliptengine.so

This will be adjusted once we update this pipeline to run in GH Actions and in combo with #33

This also updates the tests to depend on these files being in the above mentioned structure and drops windows support for now

TODO

  • Figure out what to do with the Makefile now that the output paths have changed for the lib
  • Update per client readmes


type buildFn func(context.Context, *dagger.Client, *dagger.Directory) error

func run() error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a flag argument to select languages you wish to build as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah can do that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do in a follow up

Copy link
Member

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@markphelps markphelps merged commit 6170b44 into main Dec 21, 2023
5 checks passed
@markphelps markphelps deleted the build branch December 21, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants