-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build/Package #39
Build/Package #39
Conversation
|
||
type buildFn func(context.Context, *dagger.Client, *dagger.Directory) error | ||
|
||
func run() error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a flag argument to select languages you wish to build as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah can do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do in a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Re: #38
First steps in packaging natively per ecosystem
This creates a dagger pipeline to build packages for each ecosystem.
It currently assumes that the built libraries for each arch/platform exist locally in the following structure
This will be adjusted once we update this pipeline to run in GH Actions and in combo with #33
This also updates the tests to depend on these files being in the above mentioned structure and drops windows support for now
TODO