feat: various changes related to documentation and getting java build in order #12
Conversation
yquansah
changed the title
build/main.go
Outdated
| } | ||
| sema = make(chan struct{}, 4) | ||
| sema = make(chan struct{}, 5) |
There was a problem hiding this comment.
I've seen this pattern get replicated from Flipt where I first did it.
It is designed to limit the number of concurrent goroutines to the capacity of this channel.
If the capacity is > number of goroutines started it is moot.
I meant to say something on the other repo, but didn't get around to it.
Long story short, I think you could remove the semaphore and take altogther.
I dont' think we do enough concurrently to need to dial things down. We spin up tens of concurrent builds in Flipt proper, that is why we dial it back there.
There was a problem hiding this comment.
@GeorgeMac Yeah I was just thinking about that, we dont have enough running concurrently to justify the semaphore yet. I can remove this pattern all together.
flipt-client-java/README.md
Outdated
| ```sh | ||
| ``` |
There was a problem hiding this comment.
Looks like this needs something in here?
There was a problem hiding this comment.
@GeorgeMac good catch!
… semaphore from test and build directory
This PR contains several changes for the clients which include:
flipt-node