feat: add JWT support for all the clients #13
Conversation
There was a problem hiding this comment.
one minor thing. (rust)
Also, I know we aimed to maintain backward compatibility with the existing rest SDKs, but now is the time to break anything we don't like such as naming conventions. So do you all prefer FliptAPIClient or Flipt or FliptClient, etc @yquansah @GeorgeMac
flipt-client-rust/src/lib.rs
Outdated
| pub enum AuthScheme { | ||
| None, | ||
| BearerToken(String), | ||
| JWTToken(String), |
There was a problem hiding this comment.
| JWTToken(String), | |
| JWT(String), |
Otherwise its like JSONWebTokenToken
There was a problem hiding this comment.
@markphelps Yeah That is fine. I am up for standardization as well, I like FliptClient.
| @@ -7,10 +7,10 @@ | |||
| public class FliptClient { | |||
| private Evaluation evaluation; | |||
|
|
|||
| public FliptClient(String url, String token, int timeout) { | |||
| public FliptClient(String url, String clientToken, String jwtToken, int timeout) { | |||
There was a problem hiding this comment.
does this constructor need to be public? We want to probably want to require users to user the builder right?
There was a problem hiding this comment.
@markphelps You are right. I'll make that change right away
| private final ObjectMapper objectMapper; | ||
|
|
||
| public Evaluation(OkHttpClient httpClient, String baseURL, String token) { | ||
| public Evaluation(OkHttpClient httpClient, String baseURL, String clientToken, String jwtToken) { |
There was a problem hiding this comment.
I think this would need to stay public in order for the FliptClient to access it, we could make a builder for Evaluation, but I wonder if that makes sense?
There was a problem hiding this comment.
Ah you are right. Fine to leave it as is
This PR mainly has the functionality of support JWT headers provided by the client on a HTTP request. It also refactors some clients to match the exact semantics of the old fern generated clients.