feat: use authentication strategy for configuring node sdk auth #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markphelps
commented
Jan 10, 2024
| authenticate(): Promise<Map<string, string>>; | ||
| } | ||
|
|
||
| export class ClientTokenAuthentication implements AuthenticationStrategy { |
There was a problem hiding this comment.
Im not sure what the idiomatic naming convention is here, should we prefix everything exported with Flipt or not? cc @yquansah
There was a problem hiding this comment.
@markphelps This is correct here, no flipt prefix needed!
yquansah
approved these changes
Jan 10, 2024
This was referenced Jan 10, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try out strategy pattern for configuring authentication to hopefully make it more extendable