-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add CSharp SDK #234
feat: Add CSharp SDK #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking great! thank you @vgwizardx !!
One minor change around auth headers requested, as well as a question about the srcWrong
directory/package
Also, is there a best practice for testing in C#, like a test runner/framework/pattern? I can add some integration tests once we get this merged so just wondering.
Thanks again!
[FLI-783 - C# Server Side SDK](flipt-io#86) - Add Authentication - Add Evaluation (Boolean, Variant, and Batch) - Removed hardcoded "Bearer" prefix from AuthenticationHeaderValue constructor to use the value returned by _authenticationStrategy.GetAuthorizationHeader() method for more flexibility and customization. - Also, removed unnecessary appsettings files, EvaluationController, DTOs, Models, and Program.cs. Signed-off-by: vgwizardx <[email protected]>
@markphelps I fixed the issues you mentioned. Since the srcWrong didn't show in Visual Studio, I forgot I removed it, but it must not have been deleted from the folder. Now, the header will be set by the strategy. As far as patterns for testing. Xunit is commonly used, similar to junit. This might be more than what you want, but you can do something like this for the integration test You can also use other integration testing tools like Selenium, but I haven't set anything up like that. If you just need something similar to how the Java test is set up. I probably could knock that out tonight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! thank you @vgwizardx !
No pressure! But if you are able to that would be amazing! yeah the tests are very basic at the moment, the Java one is probably a good reference as you mentioned basically it just depends on If you are able to get something going I can take it and hook it up to our CI, as we use Dagger and getting it all wired up takes a bit of time. But if not I can also take a stab at writing a test if you don't have the time. Regardless this contribution is much appreciated! We've been asked by several people to have a C# SDK and now we can say we've got one!! Thanks again @vgwizardx |
FLI-783 - C# Server Side SDK