feat: add reference to request structures #24
Conversation
yquansah
force-pushed
the
gm/thread-reference
branch
from
eddb555 to
7511485
Compare
FLI-726 Server SDKs: Allow to pass a version/ref
Allow all server side SDKs to pin to a specific version or ref |
|
@markphelps should linear be commenting on this PR? Is that a product of the repo previously being private? |
|
Yeah I think it's only because it was private previously. I don't think it will continue to do so going forward |
| @@ -12,11 +12,11 @@ public static void main(String[] args) { | |||
| context.put("fizz", "buzz"); | |||
|
|
|||
| EvaluationRequest variantEvaluationRequest = | |||
| new EvaluationRequest("default", "flag1", "entity", context); | |||
| new EvaluationRequest("default", "flag1", "entity", context, Optional.empty()); | |||
There was a problem hiding this comment.
im wondering if we should use the builder pattern here? since I would think most users wouldn't want to pass ref, and its a bit odd that we force them to pass Optional.empty() IMO
There was a problem hiding this comment.
Agreed, I think (based on Ferns approach) there is precedent for keeping this type how it is and adding a Builder as a sub-type for creating isntances of this final type. So this would still be a valid constructor, but there would be an additional builder to make this easier.
Does is make sense to tackle that as a general improvement in a subsequent PR?
…r-sdks into gm/thread-reference
Fixes FLI-726
We can hold off integrating this till the time is right.
But decided to get ahead of it.
This adds
referenceand optional parameter to all the request structures.