Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(php): resilient to network/http errors #308

Merged
merged 1 commit into from
Oct 8, 2024
Merged

feat(php): resilient to network/http errors #308

merged 1 commit into from
Oct 8, 2024

Conversation

erka
Copy link
Collaborator

@erka erka commented Oct 5, 2024 •
edited
Loading

  • add new variantValue and booleanValue with fallback value to simplify usage
  • handle json exception
  • improve api documentation

@erka erka force-pushed the php-errors branch 5 times, most recently from af35fa3 to c3e9fc7 Compare October 7, 2024 14:03
@erka erka mentioned this pull request Oct 7, 2024
Open
@erka erka marked this pull request as ready for review October 8, 2024 09:16
@erka erka requested a review from a team as a code owner October 8, 2024 09:16
markphelps
markphelps approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!! thank you @erka

@erka erka changed the title fix(php): handle json error and throws annotations feat(php): resilient to network/http errors Oct 8, 2024
@erka erka merged commit ed79011 into main Oct 8, 2024
7 checks passed
@erka erka deleted the php-errors branch October 8, 2024 20:41
@flipt-release-bot flipt-release-bot bot mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markphelps markphelps markphelps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erka @markphelps