chore: dont generate interface method

flipt-io · Nov 6, 2023 · 720accd · 720accd
1 parent a2390a3
commit 720accd
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 26 deletions.
diff --git a/internal/cmd/protoc-gen-go-flipt-sdk/grpc.go b/internal/cmd/protoc-gen-go-flipt-sdk/grpc.go
@@ -37,11 +37,8 @@ func generateGRPC(gen *protogen.Plugin) {
 
 		if len(file.Services) < 2 {
 			srv := file.Services[0]
-			if srv.Comments.Leading != "" {
-				leading := strings.TrimPrefix(string(srv.Comments.Leading), "//")
-				if strings.TrimSpace(leading) == ignoreDecl {
-					continue
-				}
+			if shouldIgnoreService(srv) {
+				continue
 			}
 
 			returnType := file.Services[0].GoName + "Client"
@@ -60,11 +57,8 @@ func generateGRPC(gen *protogen.Plugin) {
 		g.P("}\n")
 
 		for _, srv := range file.Services {
-			if srv.Comments.Leading != "" {
-				leading := strings.TrimPrefix(string(srv.Comments.Leading), "//")
-				if strings.TrimSpace(leading) == ignoreDecl {
-					continue
-				}
+			if shouldIgnoreService(srv) {
+				continue
 			}
 
 			returnType := srv.GoName + "Client"

diff --git a/internal/cmd/protoc-gen-go-flipt-sdk/http.go b/internal/cmd/protoc-gen-go-flipt-sdk/http.go
@@ -141,11 +141,8 @@ func generateHTTP(gen *protogen.Plugin, grpcAPIConfig string) {
 
 		if len(file.Services) < 2 {
 			srv := file.Services[0]
-			if srv.Comments.Leading != "" {
-				leading := strings.TrimPrefix(string(srv.Comments.Leading), "//")
-				if strings.TrimSpace(leading) == ignoreDecl {
-					continue
-				}
+			if shouldIgnoreService(srv) {
+				continue
 			}
 
 			returnType := srv.GoName + "Client"
@@ -175,11 +172,8 @@ func generateHTTP(gen *protogen.Plugin, grpcAPIConfig string) {
 		g.P("}\n")
 
 		for _, srv := range file.Services {
-			if srv.Comments.Leading != "" {
-				leading := strings.TrimPrefix(string(srv.Comments.Leading), "//")
-				if strings.TrimSpace(leading) == ignoreDecl {
-					continue
-				}
+			if shouldIgnoreService(srv) {
+				continue
 			}
 
 			var (

diff --git a/internal/cmd/protoc-gen-go-flipt-sdk/main.go b/internal/cmd/protoc-gen-go-flipt-sdk/main.go
@@ -121,6 +121,10 @@ func generateSubSDK(gen *protogen.Plugin, file *protogen.File) (typ, client stri
 
 		g.P("type ", typ, "Client interface {")
 		for _, srv := range file.Services {
+			if shouldIgnoreService(srv) {
+				continue
+			}
+
 			g.P(srv.GoName+"Client", "()", relativeImport(g, file, srv.GoName+"Client"))
 		}
 		g.P("}\n")
@@ -132,11 +136,8 @@ func generateSubSDK(gen *protogen.Plugin, file *protogen.File) (typ, client stri
 	}
 
 	for _, srv := range file.Services {
-		if srv.Comments.Leading != "" {
-			leading := strings.TrimPrefix(string(srv.Comments.Leading), "//")
-			if strings.TrimSpace(leading) == ignoreDecl {
-				continue
-			}
+		if shouldIgnoreService(srv) {
+			continue
 		}
 
 		serviceName := srv.GoName
@@ -271,3 +272,11 @@ func New(t Transport, opts ...Option) SDK {
 
     return sdk
 }`
+
+func shouldIgnoreService(srv *protogen.Service) bool {
+	if srv.Comments.Leading != "" {
+		leading := strings.TrimPrefix(string(srv.Comments.Leading), "//")
+		return strings.TrimSpace(leading) == ignoreDecl
+	}
+	return false
+}
diff --git a/sdk/go/evaluation.sdk.gen.go b/sdk/go/evaluation.sdk.gen.go