-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: libsql experiment #2178
Merged
feat: libsql experiment #2178
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0647ee7
feat(wip): libsql experiment
markphelps b35c7f0
chore: try to fix tests
markphelps dd3eba1
chore: bump all to go 1.21
markphelps c0f31a3
chore: add libsql to db actions
markphelps fea50e1
chore: db tests
markphelps aa40f7d
chore: swap to go_version var for actions
markphelps 16f1848
chore: fix config test
markphelps e7f880e
chore: errors
markphelps aaa5a1c
feat: support http and https schemes for database url
yquansah cb18b18
chore: add some go modules for fixing libsql with fork
yquansah bd360aa
chore: merge main
markphelps f4e2de2
feat: add docker-compose example for libqsl and diagrams
yquansah 6175ac8
Merge remote-tracking branch 'origin/libsql' into libsql
yquansah 2cd336b
chore: add new line at the end of docker-compose.yml
yquansah bbd2a27
chore: fix up README and polish up example
yquansah e18f2b9
chore: upgrade golangci version
yquansah 18ede80
chore: add multi-stage Dockerfile back in root and accompany libsql e…
yquansah c7750b8
chore: use different Dockerfile
yquansah 832d8a4
chore: fix ufuzi build
markphelps 82ab72a
chore: some minor README updates; set platform for sqld image
markphelps eb1c69f
chore: add test without slash for sqlite url
yquansah 8a91223
Merge remote-tracking branch 'origin/libsql' into libsql
yquansah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,15 +15,15 @@ jobs: | |
|
|
||
| - uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: "1.20" | ||
| go-version: "${{ vars.GO_VERSION }}" | ||
| check-latest: true | ||
| cache: true | ||
|
|
||
| - name: golangci-lint | ||
| uses: golangci/[email protected] | ||
| with: | ||
| # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version. | ||
| version: v1.52.1 | ||
| version: v1.54.2 | ||
| skip-pkg-cache: true | ||
| skip-build-cache: true | ||
| args: --timeout=10m | ||
|
|
@@ -66,7 +66,7 @@ jobs: | |
|
|
||
| - uses: actions/setup-go@v4 | ||
| with: | ||
| go-version: "1.20" | ||
| go-version: "${{ vars.GO_VERSION }}" | ||
| check-latest: true | ||
| cache: true | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,8 @@ | ||
| FROM golang:1.20-alpine3.16 | ||
| FROM golang:1.21-alpine3.18 AS build | ||
|
|
||
| WORKDIR /server | ||
| WORKDIR /home/flipt | ||
|
|
||
| RUN apk add --update --no-cache git bash gcc build-base binutils-gold \ | ||
| openssl \ | ||
| ca-certificates \ | ||
| postgresql-client | ||
| RUN apk add --update --no-cache npm git bash gcc build-base binutils-gold | ||
|
|
||
| RUN git clone https://github.com/magefile/mage && \ | ||
| cd mage && \ | ||
|
|
@@ -17,10 +14,39 @@ COPY ./errors ./errors | |
| COPY ./rpc/flipt ./rpc/flipt | ||
| COPY ./sdk ./sdk | ||
|
|
||
| RUN go mod download -x | ||
| RUN go mod download | ||
|
|
||
| COPY . /home/flipt | ||
|
|
||
| ENV CGO_ENABLED=1 | ||
|
|
||
| RUN mage bootstrap && \ | ||
| mage build | ||
|
|
||
| FROM alpine:3.16.2 | ||
|
|
||
| LABEL maintainer="[email protected]" | ||
| LABEL org.opencontainers.image.name="flipt" | ||
| LABEL org.opencontainers.image.source="https://github.com/flipt-io/flipt" | ||
|
|
||
| RUN apk add --update --no-cache postgresql-client \ | ||
| openssl \ | ||
| ca-certificates | ||
|
|
||
| RUN mkdir -p /etc/flipt && \ | ||
| mkdir -p /var/opt/flipt | ||
| mkdir -p /var/opt/flipt && \ | ||
| mkdir -p /var/log/flipt | ||
|
|
||
| COPY --from=build /home/flipt/bin/flipt / | ||
| COPY config/*.yml /etc/flipt/config/ | ||
|
|
||
| RUN addgroup flipt && \ | ||
| adduser -S -D -g '' -G flipt -s /bin/sh flipt && \ | ||
| chown -R flipt:flipt /etc/flipt /var/opt/flipt /var/log/flipt | ||
|
|
||
| EXPOSE 8080 | ||
| EXPOSE 9000 | ||
| EXPOSE 9000 | ||
|
|
||
| USER flipt | ||
|
|
||
| CMD ["./flipt"] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| FROM golang:1.21-alpine3.18 | ||
|
|
||
| WORKDIR /server | ||
|
|
||
| RUN apk add --update --no-cache git bash gcc build-base binutils-gold \ | ||
| openssl \ | ||
| ca-certificates \ | ||
| postgresql-client | ||
|
|
||
| RUN git clone https://github.com/magefile/mage && \ | ||
| cd mage && \ | ||
| go run bootstrap.go | ||
|
|
||
| COPY go.mod . | ||
| COPY go.sum . | ||
| COPY ./errors ./errors | ||
| COPY ./rpc/flipt ./rpc/flipt | ||
| COPY ./sdk ./sdk | ||
|
|
||
| RUN go mod download -x | ||
|
|
||
| RUN mkdir -p /etc/flipt && \ | ||
| mkdir -p /var/opt/flipt | ||
|
|
||
| EXPOSE 8080 | ||
| EXPOSE 9000 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module tools | ||
|
|
||
| go 1.20 | ||
| go 1.21 | ||
|
|
||
| require ( | ||
| github.com/bufbuild/buf v1.9.0 | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| FROM golang:1.20-alpine3.16 | ||
| FROM golang:1.21-alpine3.18 | ||
|
|
||
| WORKDIR /flipt | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| module go.flipt.io/flipt/build | ||
|
|
||
| go 1.20 | ||
| go 1.21 | ||
|
|
||
| require ( | ||
| code.gitea.io/sdk/gitea v0.15.1 | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this one still needed?
I can't remember how that conversation ended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it still is for the dev docker-compose to not build the UI in the Go binary