Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support scoped namespace tokens for evaluation data api #3452

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

markphelps
Copy link
Collaborator

Re: #3438

Adds support for namespace scoped tokens for evaluation data api

@markphelps markphelps requested a review from a team as a code owner September 9, 2024 20:11
Signed-off-by: Mark Phelps <[email protected]>
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.68%. Comparing base (dd6a0a0) to head (c1a3e0e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/server/evaluation/data/server.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3452      +/-   ##
==========================================
- Coverage   64.69%   64.68%   -0.01%     
==========================================
  Files         174      174              
  Lines       13918    13920       +2     
==========================================
  Hits         9004     9004              
- Misses       4225     4227       +2     
  Partials      689      689              
Flag Coverage Δ
unittests 64.68% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Sep 10, 2024
@kodiakhq kodiakhq bot merged commit b69549a into main Sep 10, 2024
65 of 67 checks passed
@kodiakhq kodiakhq bot deleted the support-namespace-tokens-client-eval branch September 10, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants