refactor(cache): use namespace.version as part of cache key #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erka
force-pushed
the
rd/cache-storage
branch
3 times, most recently
from
76e75be to
89ca41e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3743 +/- ##
==========================================
+ Coverage 64.61% 64.86% +0.25%
==========================================
Files 170 170
Lines 17241 17359 +118
==========================================
+ Hits 11140 11260 +120
+ Misses 5406 5405 -1
+ Partials 695 694 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
erka
force-pushed
the
rd/cache-storage
branch
3 times, most recently
from
296f6c2 to
4587e3c
Compare
As namespace has a version which updates on each configuration changes it makes sense to use it as part of the cache key. Changes focus on improving the evaluation response time. All other API calls is not in a critical path so there is very little benefits to cache them Signed-off-by: Roman Dmytrenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As namespace has a version which updates on each configuration changes
it makes sense to use it as part of the cache key. Changes focus on
improving the evaluation response time. All other API calls is not in a
critical path so there is very little benefits to cache them