Skip to content

Conversation

erka
Copy link
Contributor

@erka erka commented Oct 6, 2025

This pull request improves the handling of environment selection in the environment store, especially around the use of the "default" environment key. The main change ensures that when an environment with the key "default" doesn't exist, the system will gracefully fall back to the actual default environment (even if it has a different key), which increases compatibility with SDKs and simplifies environment management.

related #4856

@erka erka requested a review from a team as a code owner October 6, 2025 18:36
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 6, 2025
Copy link

dosubot bot commented Oct 6, 2025

Related Documentation

Checked 4 published document(s). No updates required.

You have 1 draft document(s). Publish docs to keep them always up-to-date

How did I do? Any feedback?  Join Discord

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.62%. Comparing base (bedc518) to head (5cdc66a).
⚠️ Report is 3 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #4857      +/-   ##
==========================================
+ Coverage   58.57%   58.62%   +0.04%     
==========================================
  Files         135      135              
  Lines       16844    16850       +6     
==========================================
+ Hits         9867     9878      +11     
+ Misses       6292     6287       -5     
  Partials      685      685              
Flag Coverage Δ
integrationtests 33.92% <57.14%> (+0.01%) ⬆️
unittests 49.31% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erka erka changed the title fix: ensure compatibility with SDKs with default environment fix: ensure compatibility with SDKs and default environment Oct 6, 2025
@erka erka added the v2 Flipt v2 label Oct 6, 2025
@erka erka linked an issue Oct 6, 2025 that may be closed by this pull request
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Oct 8, 2025
@kodiakhq kodiakhq bot merged commit f0617b1 into v2 Oct 8, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this to Done in Flipt V2 Oct 8, 2025
@kodiakhq kodiakhq bot deleted the rd/v2/env-ref branch October 8, 2025 15:18
Copy link

dosubot bot commented Oct 8, 2025

Documentation Updates

Checked 4 published document(s). No updates required.

You have 1 draft document(s). Publish docs to keep them always up-to-date

How did I do? Any feedback?  Join Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Used by Kodiak bot to automerge PRs size:L This PR changes 100-499 lines, ignoring generated files. v2 Flipt v2

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Environment Reference Does Not Work as Documented

2 participants