[FIX] Use a instead of A binary decoding in Protocol.php (#45)

* Use `a` instead of `A` binary decoding in `Protocol.php` * Fix `SchemaAttribute` failure for PHPStan
flix-tech · Nov 2, 2020 · cf5b0bb · cf5b0bb
1 parent 4bfeb36
commit cf5b0bb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/Objects/Schema/Generation/AnnotationReader.php b/src/Objects/Schema/Generation/AnnotationReader.php
@@ -25,6 +25,7 @@ public function __construct(DoctrineAnnotationReader $reader)
      */
     public function readClassAttributes(ReflectionClass $class): SchemaAttributes
     {
+        /** @var SchemaAttribute[] $annotations */
         $annotations = $this->reader->getClassAnnotations($class);
         $attributes = \array_filter($annotations, [$this, 'onlySchemaAttributes']);
 
@@ -33,6 +34,7 @@ public function readClassAttributes(ReflectionClass $class): SchemaAttributes
 
     public function readPropertyAttributes(ReflectionProperty $property): SchemaAttributes
     {
+        /** @var SchemaAttribute[] $annotations */
         $annotations = $this->reader->getPropertyAnnotations($property);
         $attributes = \array_filter($annotations, [$this, 'onlySchemaAttributes']);
 

diff --git a/src/Protocol.php b/src/Protocol.php
@@ -30,15 +30,15 @@ function version(): int
 function encode(int $protocolVersion, int $schemaId, string $avroEncodedBinaryString): Either
 {
     /** @var bool|string $packed */
-    $packed = @\pack('CNA*', $protocolVersion, $schemaId, $avroEncodedBinaryString);
+    $packed = @\pack('CNa*', $protocolVersion, $schemaId, $avroEncodedBinaryString);
 
     return false !== $packed
         ? Right::of($packed)
         // @codeCoverageIgnoreStart
         : Left::of(
             new AvroEncodingException(
                 \sprintf(
-                    'Could not pack message with format "CNA*", protocol version "%d" and schema id "%d"',
+                    'Could not pack message with format "CNa*", protocol version "%d" and schema id "%d"',
                     $protocolVersion,
                     $schemaId
                 )