Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git on android/ios doesn't work #1608

Open
1 task
mortifactor opened this issue May 12, 2024 · 21 comments
Open
1 task

Git on android/ios doesn't work #1608

mortifactor opened this issue May 12, 2024 · 21 comments

Comments

@mortifactor
Copy link

Which version of floccus are you using?

5.1.1

How many bookmarks do you have, roughly?

1000+

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

Git

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Android 9 Honor 20

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

I'm importing profile from browser, which works. But I tried creating same profile from scratch and it did not work either.
Profile uses github private repository.
So I have "Failed to fetch" error after sync. And if I go to settings I get blank screen. That is why I can't attach debug logs.
You can see it on video below.

Expected Behavior

Well, it should sync I believe.

To Reproduce

222.mp4

Debug log provided

  • I have provided a debug log file
Copy link

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus and have been maintaining it ever since.
I currently work for Nextcloud which leaves me with less time for side projects like this one
than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

@marcelklehr
Copy link
Member

It's possible this is a network problem. I'll look into the settings issue.

@babblerz
Copy link

I have the same issue. Using 5.1.2. This is what I get in the android log:

Capacitor/Console: File: http://localhost/#/tree/17158905901720.4856727622664514 - Line 0 - Msg: Access to fetch at 'https://redacted.com/redactedusername/floccusbookmarks/info/refs?service=git-upload-pack' from origin 'http://localhost' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

The same server with the browser plugin works ok.
Also tried it with a github.com account and the error is the same.

@marcelklehr
Copy link
Member

Ah, thank you for the extended log, @babblerz The error makes sense now. I'll look into fixing this.

@marcelklehr
Copy link
Member

Fixed the settings issue. I can reproduce the CORS issue, I'll look into fixing it.

@marcelklehr marcelklehr changed the title "Failed to fetch" and blank settings screen in android app using git Git on android: "Failed to fetch" May 17, 2024
@marcelklehr marcelklehr moved this to To Do: Bugs in Floccus May 19, 2024
@marcelklehr
Copy link
Member

Upstream blocker: ionic-team/capacitor#7473

@dcanl
Copy link

dcanl commented May 28, 2024

Hello,

Just posting to follow this issue which I encounter myself too.

Thank you for your work!

@mdcayton
Copy link

Similar issue. Looks like if fails to checkout the branch.

2024-05-31T16:44:21.293Z Starting sync process for account user@[email protected]:bookmarks.xbel
2024-05-31T16:44:21.300Z onSyncStart: begin
2024-05-31T16:44:21.302Z (git) init
2024-05-31T16:44:21.392Z (git) fetch from remote
2024-05-31T16:44:21.810Z (git) checkout branch main
2024-05-31T16:44:21.826Z onSyncFail
2024-05-31T16:44:21.830Z Syncing failed with Failed to checkout "main" because commit ##### is not available locally. Do a git fetch to make the branch available locally.
2024-05-31T16:44:21.840Z onSyncFail

@faan11
Copy link

faan11 commented Jun 15, 2024

Hi @marcelklehr
any updates about this issue? Today I have installed the application and i faced this issue with the same error log.

@marcelklehr
Copy link
Member

@faan11 Sadly not, it's an upstream issue in capacitor: ionic-team/capacitor#7473

@marcelklehr marcelklehr pinned this issue Jun 23, 2024
@bigdiff
Copy link
Contributor

bigdiff commented Jul 10, 2024

The upstream issue seems to have been fixed: ionic-team/capacitor#7473 (comment)

@marcelklehr
Copy link
Member

Yes, now we need to wait for a release from them, then this issue can be fixed :)

@Crunchbits
Copy link

Looks like a release was just made from them with the fix

@faan11
Copy link

faan11 commented Jul 17, 2024

Yeah the issue has been fixed in the upstream with version v5.7.7 or v6.1.1

@marcelklehr
Copy link
Member

marcelklehr commented Jul 20, 2024

Mmmh, now with the latest capacitor version it just hangs on git fetch 🤔

It seems they have more bugs in their fetchAPI implementation

@marcelklehr marcelklehr changed the title Git on android: "Failed to fetch" Git on android doesn't work Jul 20, 2024
@marcelklehr marcelklehr changed the title Git on android doesn't work Git on android/ios doesn't work Aug 5, 2024
@ChandraSaiKarthik
Copy link

ChandraSaiKarthik commented Oct 15, 2024

I had a similar issue (hangs with sync and hangs complete mobile) with gitea on my OnePlus Mobile running Android 14.1 but syncs smoothly on my laptop.
Let me know what other details you might need for troubleshooting.

@elvisisvan
Copy link

I had a similar issue (hangs with sync and hangs complete mobile) with gitea on my OnePlus Mobile running Android 14.1 but syncs smoothly on my laptop. Let me know what other details you might need for troubleshooting.

so floccus mobile git sync is not working for your phone too? my samsung phone running android 12 floccus v5.3.1 is having the same issue, the app refreshes countless times and still no bookmark appears

Screenshot_20241102_132653_floccus bookmark sync

@unavailable500

This comment was marked as duplicate.

@yashovardhan99

This comment was marked as duplicate.

@endlesssecurity

This comment was marked as duplicate.

@marcelklehr
Copy link
Member

marcelklehr commented Nov 27, 2024

Please don't comment unless you have a substantial contribution for this discussion. Git is known to not work on Android until the capacitor http implementation is fixed, sadly (see #1608 (comment) ). I'm sorry about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: On hold
Development

No branches or pull requests