Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync fails if pipe character "|" exists in bookmark title #1800

Open
1 task
vogtgbr opened this issue Dec 15, 2024 · 6 comments
Open
1 task

Sync fails if pipe character "|" exists in bookmark title #1800

vogtgbr opened this issue Dec 15, 2024 · 6 comments

Comments

@vogtgbr
Copy link

vogtgbr commented Dec 15, 2024

Which version of floccus are you using?

5.4.0

How many bookmarks do you have, roughly?

3k

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

WebDAV

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Firefox

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

If there exists a pipe character
|
in the title of a bookmark like so:
<bookmark href="https://www.thingiverse.com/thing:6542198" id="5457">
<title>One-Handed Soldering Tool 2.0 | Effortless Soldering With Only One Hand by RoboticWorx - Thingiverse</title>
</bookmark>
and a sync runs and puts this in the .xbel file on the WebDav, all consecutive syncs from any device will fail with
Content-Length header of network response exceeds response Body. |
Interestingly the error message contains the character that causes the trouble.

Expected Behavior

Pipe characters in bookmark titles should not cause trouble. ;)

To Reproduce

1.) Create a bookmark with a title that contains character | (pipe)
2.) Let it sync upward so that all devices can see this bookmark
3.) Sync again to get the error message.

Debug log provided

  • I have provided a debug log file
@vogtgbr vogtgbr added the bug label Dec 15, 2024
Copy link

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
To continue the development and maintenance of this project in a sustainable way it is expected that you donate to the project when opening a ticket,
if you're not a donor already. You can find donation options at https://floccus.org/donate/. Thank you!

One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

@marcelklehr
Copy link
Member

Hi @vogtgbr

I believe you are mistaken about the pipe character being the problem. I have multiple bookmarks with pipes in the title that sync fine.

The pipe character is intentionally part of the error message:
image

The error message in your case indicates that your server has a problem: Content-Length header of network response exceeds response Body.

@github-project-automation github-project-automation bot moved this to Backlog in Floccus Dec 15, 2024
@marcelklehr marcelklehr moved this from Backlog to Triaging in Floccus Dec 15, 2024
@vogtgbr
Copy link
Author

vogtgbr commented Dec 15, 2024

Hi Marcel,
thats really strange. I manually edited the bookmarks.xbel file on the WebDav server and changed only this single character from | to -. That did the trick, syncing worked again without problems after that. However, you are right, I discovered now that I have several titles with a pipe character myself, so this can't be the (only) reason for the problem.
I'll try to do more research on this matter and if I figure out more, I'll be happy if I may tell you about it. For now, I guess you can close this issue.
Thanks for your time!

@marcelklehr
Copy link
Member

Nah, let's leave this open until we figure it out :)

@marcelklehr
Copy link
Member

I manually edited the bookmarks.xbel file on the WebDav server and changed only this single character from | to -.

It may have been just the edit that made it work?

@vogtgbr
Copy link
Author

vogtgbr commented Dec 17, 2024

Jep, I didn't do anything else and I don't know why it started working again. Maybe the time stamp of bookmarks.xbel was the reason? It must have changed when I edited it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triaging
Development

No branches or pull requests

2 participants