Skip to content

Commit

Permalink
Fix tests (php-cs-fixer) and update GitHub actions (mozfr#1036)
Browse files Browse the repository at this point in the history
* Update GitHub actions
* Run php-cs-fixer
  • Loading branch information
flodolo authored Feb 29, 2024
1 parent 1f99fe2 commit 027817f
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
- '8.2'
steps:
- name: Check out repository
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Set up Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: '16'

Expand All @@ -39,7 +39,7 @@ jobs:
run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT

- name: Cache dependencies
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ${{ steps.composer-cache.outputs.dir }}
key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
Expand Down
18 changes: 9 additions & 9 deletions app/classes/Transvision/Consistency.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,12 @@ public static function findDuplicates($strings_array, $case_sensitive = True)
/**
* Filter out strings that should not be evaluted for consistency.
*
* @param array $strings_array Array of strings in the form
* string_id => string_value
* @param array $strings_array Array of strings in the form
* string_id => string_value
* @param string Repository identifier
*
* @return array Array of filtered strings, with known false positives
* removed
* @return array Array of filtered strings, with known false positives
* removed
*/
public static function filterStrings($strings_array, $repo)
{
Expand Down Expand Up @@ -107,12 +107,12 @@ public static function filterStrings($strings_array, $repo)
/**
* Filter out strings that belong to a group of components
*
* @param array $strings_array Array of strings in the form
* string_id => string_value
* @param array $components Array of component names
* @param array $strings_array Array of strings in the form
* string_id => string_value
* @param array $components Array of component names
*
* @return array Array of filtered strings, with strings belonging
* to requested components removed
* @return array Array of filtered strings, with strings belonging
* to requested components removed
*/
public static function filterComponents($strings_array, $components)
{
Expand Down

0 comments on commit 027817f

Please sign in to comment.