sokol_imgui.h: simplify ImTextureID handling. #1169
Merged
+203
−398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Dear ImGui's ImTextureID is now guaranteed to be 64 bits, the sokol-gfx image+sampler pair can now be stashed directly into the ImTextureID instead of requiring a 'backing object'. This simplifies the sokol_imgui.h implementation drastically.
Also: in sokol_gfx.h, add granular
sg_query_buffer_X()andsg_query_image_X()functions which allow to cheaply query buffer and image properties without having to return a big desc struct (might make sense to extend for samplers, but probably less useful for shaders, pipelines and attachments).TODO: