-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingestor highlight #29
Conversation
{ chainId: 8453, contractAddress: '0x0E5DDe3De7cf2761d8a81Ee68F48410425e2dBbA' }, | ||
{ chainId: 8453, contractAddress: '0xBE96B2572CA0F1ac8ec6323Bc9037AffD270bA7F' }, | ||
], | ||
failureContracts: [{ chainId: 5000, contractAddress: '0x62F8C536De24ED32611f128f64F6eAbd9b82176c' }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recommend adding the final parameter here to ensure these tests always pass, declaring the blockhash to run simulation as of (this is the current blockhash atow)
{
8453: '0x108D2CF'
}
Looks great! Full test suite including simulation works locally!
Let me know when you're ready for final review and merging 🥳 (mark as ready for review) |
@pbkompasz this is approved. Can you add a twitter or email to your Github profile so that I can message you the claim form for the bounty? 🙏 |
@chrismaddern You can reach me here: [email protected] |
Mint Ingestor: Highlight (#11)
Functionality Supported
Before you submit
src/ingestors
myMintingPlatformGetContractDetails
resources
object