Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-zora-base ingestor #40

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Nith567
Copy link

@Nith567 Nith567 commented Aug 14, 2024

Mint Ingestor: ZORA

Functionality Supported

  • Ingesting from URL: Yes
  • Ingesting from Contract address: Yes
  • Supported Networks: Base

Before you submit

  • Ensure your generated MintTemplate works 😄
  • Ensure that your code is restricted to a single folder in src/ingestors
  • Ensure that all required assets are included (e.g. ABIs)
  • Ensure ABIs are trimmed to include only methods (1) used in the ingestor or (2) required to mint
  • Ensure that all exported methods are prefixed with the name of your ingestor e.g. myMintingPlatformGetContractDetails
  • Ensure that a test exists for generating a MintTemplate that will always succeed
  • Ensure that your code accesses no external resources except those passed in the resources object

@Nith567
Copy link
Author

Nith567 commented Aug 14, 2024

@chrismaddern I have created with new branch, pls review this and what is the process of claiming bounty ?

@Nith567
Copy link
Author

Nith567 commented Aug 15, 2024

@chrismaddern @ckorhonen Can you pls give me an update ? You can reach out to me : [email protected]

@chrismaddern
Copy link
Contributor

Apologies @Nith567 I got pretty under water. Will do a full review of all outstanding PRs in the next day.

Unfortunately, many ingestors have had issues that have required 5+ rounds of feedback and has taken up more time than we really had to commit to this, but I will make sure to close these out.

@Nith567
Copy link
Author

Nith567 commented Aug 22, 2024

@chrismaddern I was the first one to make PR(ZORA-BASE-MINT) , unfortuantely rounds of feedback(long gap) took more than a month it could have done all in a week. Hoping to get reward previous PR was removed due to changes made on main branch. This literally took out 2 months for me hoping to get a bounty for being this long 🙂

@chrismaddern
Copy link
Contributor

unfortuantely rounds of feedback(long gap) took more than a month it could have done all in a week

Hi @Nith567 you are correct - you have submitted the largest number of unsuccessful, non-working PR submissions of any bounty submission. This PR seems to have been re-created from this earlier one.

#18

I have patiently allowed you to continue to attempt to get this working, and in the meantime, created a temporary one (even used the slug zora-internal to allow your work to target being the zora one).

I have continued to give feedback, and help coach on how to successfully write an ingestor, committed to helping you finish. Candidly, I did not expect to receive attitude on the other side of that - I have spent more time trying to help you write this than it would have taken to write it myself.

At this point, let me know if you believe this is a fully working submission and we'll give it one more review attempt before we entertain other submissions for this bounty.

@chrismaddern chrismaddern self-requested a review August 26, 2024 20:56
@chrismaddern
Copy link
Contributor

I just tried to take a look anyway, to see if I could get it across the line quickly, and it appears the automated tests are still failing:

CleanShot 2024-08-27 at 07 40 20@2x

@Nith567 can you add a Twitter or email to your Github profile so that I can message you 👀 🙏 😊

@Nith567
Copy link
Author

Nith567 commented Aug 27, 2024

@chrismaddern Oh sorry for that i made few changes ( actually didnt check last time it was worked so didnt even think about a moment)
Now its working :) My email ID is : ([email protected])

Screenshot 2024-08-28 at 1 02 01 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants