-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat-zora-base ingestor #40
base: main
Are you sure you want to change the base?
Conversation
@chrismaddern I have created with new branch, pls review this and what is the process of claiming bounty ? |
@chrismaddern @ckorhonen Can you pls give me an update ? You can reach out to me : [email protected] |
Apologies @Nith567 I got pretty under water. Will do a full review of all outstanding PRs in the next day. Unfortunately, many ingestors have had issues that have required 5+ rounds of feedback and has taken up more time than we really had to commit to this, but I will make sure to close these out. |
@chrismaddern I was the first one to make PR(ZORA-BASE-MINT) , unfortuantely rounds of feedback(long gap) took more than a month it could have done all in a week. Hoping to get reward previous PR was removed due to changes made on main branch. This literally took out 2 months for me hoping to get a bounty for being this long 🙂 |
Hi @Nith567 you are correct - you have submitted the largest number of unsuccessful, non-working PR submissions of any bounty submission. This PR seems to have been re-created from this earlier one. I have patiently allowed you to continue to attempt to get this working, and in the meantime, created a temporary one (even used the slug I have continued to give feedback, and help coach on how to successfully write an ingestor, committed to helping you finish. Candidly, I did not expect to receive attitude on the other side of that - I have spent more time trying to help you write this than it would have taken to write it myself. At this point, let me know if you believe this is a fully working submission and we'll give it one more review attempt before we entertain other submissions for this bounty. |
I just tried to take a look anyway, to see if I could get it across the line quickly, and it appears the automated tests are still failing: @Nith567 can you add a Twitter or email to your Github profile so that I can message you 👀 🙏 😊 |
@chrismaddern Oh sorry for that i made few changes ( actually didnt check last time it was worked so didnt even think about a moment) |
Mint Ingestor: ZORA
Functionality Supported
Before you submit
src/ingestors
myMintingPlatformGetContractDetails
resources
object