Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor boxes2rst #582

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Refactor boxes2rst #582

merged 2 commits into from
Sep 5, 2023

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Sep 3, 2023

  • add callable main function
  • use f-strings
  • fix wrong description
  • add .py extension to boxes2rst script

@Rotzbua
Refactor boxes2rst
ca0990d 
* add callable `main` function
* use f-strings
* fix wrong description
@florianfesti
Copy link
Owner

Could you please stop dropping the executable bit from scripts - even if it is not technically needed after this change.

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Sep 5, 2023

Could you please stop dropping the executable bit from scripts - even if it is not technically needed after this change.

No, because it was never intended. 😕
I realized that under windows git does not recognize a rename as suggested. It seems it is a delete and new file which then has not set the execution-bit properly.
Is there a easy way to get this solved automatically like .gitattribute and then set a property?

@florianfesti
Copy link
Owner

No idea. I have not yet looked into .gitattribute

@florianfesti florianfesti merged commit 26716a4 into florianfesti:master Sep 5, 2023
4 checks passed
@Rotzbua Rotzbua deleted the refactor_boxes2rst branch September 6, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rotzbua @florianfesti