Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(python): require 3.9; drop eol 3.8 #716

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Oct 20, 2024

Python 3.8 is eol since 07 Oct 2024. Python 3.13 not added yet, because of behavour change.

Fixes tests by excluding broken generator console.

@Rotzbua Rotzbua marked this pull request as draft October 20, 2024 02:14
@Rotzbua
Copy link
Contributor Author

Rotzbua commented Oct 20, 2024

@florianfesti FYI

The test fails with python 3.13 because the created svg is different. Spaces are missing because python changed how they handle doc strings:

The compiler now strips common leading whitespace from every line in a docstring.

https://docs.python.org/3/whatsnew/3.13.html#other-language-changes

Inconspicuous change with interesting effects....

@Rotzbua Rotzbua force-pushed the up_python branch 2 times, most recently from 21d45e9 to 09b3391 Compare October 25, 2024 12:07
@Rotzbua Rotzbua force-pushed the up_python branch 2 times, most recently from f430053 to 2e947da Compare November 4, 2024 16:16
@Rotzbua Rotzbua marked this pull request as ready for review November 4, 2024 16:21
@florianfesti florianfesti merged commit eb5bbd8 into florianfesti:master Nov 4, 2024
3 checks passed
@Rotzbua Rotzbua deleted the up_python branch November 6, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants