Remove Joda Time support #4127
Remove Joda Time support #4127
Conversation
...-dmn-engine/src/test/java/org/flowable/dmn/engine/test/runtime/HitPolicyOutputOrderTest.java
Outdated
Show resolved
Hide resolved
...-engine-common/src/main/java/org/flowable/common/engine/impl/logging/LoggingSessionUtil.java
Outdated
Show resolved
Hide resolved
...-engine-common/src/main/java/org/flowable/common/engine/impl/logging/LoggingSessionUtil.java
Outdated
Show resolved
Hide resolved
...e-engine/src/test/java/org/flowable/engine/test/bpmn/usertask/TaskDueDateExtensionsTest.java
Outdated
Show resolved
Hide resolved
|
Good catch @dbmalkovsky. Thanks |
Add support for reading Joda Time variables as Joda Time by using flowable.joda-time-variable-support with value write
filiphr
force-pushed
the
joda-removal
branch
from
415ff45 to
0f21a9e
Compare
| <ul> | ||
| <li><code>DISABLE</code> - Completely disables Joda Time. If you have Joda Time variables in the database then reading those variables will fail. | ||
| </li> | ||
| <li><code>READ_AS_JAVA_TIME</code> - Reads Joda Time variables from the database as Joda LocalDate and DateTime. This is the default configuration. |
There was a problem hiding this comment.
Use case:
Completed process/case instance stores joda time variable.
Question:
Do we need to support at least read (if we reopen the case + write) for the time till the instance is not deleted from the history?
There was a problem hiding this comment.
Sorry, but I am not quite following what you are asking @martin-grofcik. They would be read as Java Time when the READ_AS_JAVA_TIME is used. That's the idea at least. Why would you need to read and not write as Joda Time variables?
From a custom code perspective, you'll need to adjust to Java Time. From a Flowable point of view, Joda time variables won't be supported. Old variables would still work as they would be read as Java time.
There was a problem hiding this comment.
Keep in mind that this is still work in progress, we have not made a final decision for how it should look like.
There was a problem hiding this comment.
"work in progress" - yes that's why I am asking.
My understanding of the implementation for currently running instance with joda time variables:
READ_AS_JAVA_TIME - read joda time variable..... I do not take care of writing (done with Java Time).
It means if I have joda time variable in a case/process history, I have to use JodaDateTimeFallbackType to be able to read the variable.
3 participants
This PR removes the support for Joda Time.
Joda variables will be read from the database as Java Time