Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: inject css to components #2

Merged
merged 3 commits into from
Jul 18, 2024
Merged

chore: inject css to components #2

merged 3 commits into from
Jul 18, 2024

Conversation

alexarassat
Copy link
Contributor

No description provided.

@alexarassat alexarassat requested a review from ondreian July 11, 2024 13:26
Copy link
Contributor

@ondreian ondreian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable!

fs.readdirSync(dir, {
withFileTypes: true
})
.filter(dirent => dirent.isDirectory())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dirent is a really weird variable name, what's this mean?

Copy link
Contributor Author

@alexarassat alexarassat Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ondreian ondreian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ondreian ondreian merged commit 4bd864a into main Jul 18, 2024
1 check failed
@ondreian ondreian deleted the chore/inject-css branch July 18, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants