Removing qmk environment until we fix it #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floxbot
added
team-developer-support
stahnma
force-pushed
the
chore-update-qmk-environment
branch
from
a79a690
to
8575045
Compare
stahnma
approved these changes
Nov 19, 2024
tomberek
force-pushed
the
chore-update-qmk-environment
branch
from
8575045
to
ee26f1b
Compare
|
Failure related to recent changes in GHA and Xcode version. |
tomberek
previously requested changes
Nov 19, 2024
tomberek
force-pushed
the
chore-update-qmk-environment
branch
from
01195f4
to
34ee4af
Compare
garbas
changed the title
qmk flox environment
|
@zmitchell I'm removing the environment but I don't want to. Reason: it is requiring XCode on MacOS and with recent change on macos builder we noticed this. There is still debate if we should allow this in floxenvs environments or not and how we configure our builders. If you find the time to revert this removal and make it not depend on XCode I would be very happy to review it and merge ASAP. This will allow us to have green builds again and flox environments will be updated again. |
garbas
approved these changes
Nov 20, 2024
|
Makes sense, thanks for the ping |
garbas
dismissed
tomberek’s stale review
Not relevant in this PR, I hope we can bring the qmk back
|
Ah, I started trying to fix it... no prob. Removal is simpler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by Update workflow.