This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
chore: untangle resolver mixin #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysndr
force-pushed
the
fix/ga-registry-flag-segfault
branch
from
3b3c56d
to
a62b110
Compare
|
only pushed the hh files, classic |
ysndr
force-pushed
the
fix/ga-registry-flag-segfault
branch
from
9a3f00b
to
a662406
Compare
aakropotkin
approved these changes
Dec 1, 2023
| */ | ||
| [[nodiscard]] const EnvironmentManifest & |
There was a problem hiding this comment.
What was the rationale for dropping [[nodiscard]] here?
| /* -------------------------------------------------------------------------- */ | ||
|
|
||
| void | ||
| EnvironmentManifest | ||
| GAEnvironmentMixin::initManifest( ManifestRaw manifestRaw ) | ||
| { | ||
| if ( this->gaRegistry ) | ||
| { | ||
| (void) static_cast<ManifestRawGA>( manifestRaw ); |
There was a problem hiding this comment.
non-blocking note:
This type of expression (void) EXPR is how we explicitly discard if we really want to ignore a [[nodiscard]].
This is basically only useful for tests; but wanted to highlight it since it's useful.
aakropotkin
suggested changes
Dec 1, 2023
aakropotkin
approved these changes
Dec 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #189