Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COM-4967 Split gstreamer 0.10 and 1.0 logic to remove 0.10 (deprecated) #182

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

rsanchez87
Copy link
Contributor

No description provided.

@obbardc
Copy link
Contributor

obbardc commented Jul 25, 2024

What's happening to the master branch ?

@rsanchez87
Copy link
Contributor Author

What's happening to the master branch ?

Hello Christopher, this PR intends to remove everything related to 0.10 in master branch (0.10 is more than 10 years old...)

@rsanchez87 rsanchez87 requested a review from mdimopoulos July 25, 2024 07:43
@obbardc
Copy link
Contributor

obbardc commented Jul 25, 2024

Makes sense. I thought this was splitting away from master ;-)

@rsanchez87 rsanchez87 changed the title Split gstreamer 0.10 and 1.0 logic into separate branches Split gstreamer 0.10 and 1.0 logic to remove 0.10 in master Jul 25, 2024
@rsanchez87
Copy link
Contributor Author

Makes sense. I thought this was splitting away from master ;-)

I have updated the name of the PR for more clarity, it wasn't very descriptive really, thanks!

@rsanchez87 rsanchez87 changed the title Split gstreamer 0.10 and 1.0 logic to remove 0.10 in master Split gstreamer 0.10 and 1.0 logic to remove 0.10 (deprecated) Jul 25, 2024
@mdimopoulos mdimopoulos changed the title Split gstreamer 0.10 and 1.0 logic to remove 0.10 (deprecated) COM-4967 Split gstreamer 0.10 and 1.0 logic to remove 0.10 (deprecated) Jul 26, 2024
Copy link
Contributor

@mdimopoulos mdimopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All else looks good to me!

@rsanchez87
Copy link
Contributor Author

By the way i had completely forgotten about pyproject.toml, could you add all the missing test suites in the section [tool.setuptools.data-files]

All else looks good to me!

I'm going to add these ts in the task if you see it well:

https://fluendo.atlassian.net/browse/COM-10938

@rsanchez87 rsanchez87 merged commit cc9fb13 into master Jul 26, 2024
3 checks passed
@rsanchez87 rsanchez87 deleted the 1.0 branch July 26, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants